Repository navigation
fix(web-shell): encode vision model picker selection & polish dispatch #6236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f4cf903
fix(web-shell): encode vision model selection & polish picker
atlarix-agent b22641c
fix(web-shell): encode vision model selection & polish picker
atlarix-agent f2d5079
Merge branch 'fix/vision-model-picker-encoding' into main
AmariahAK 100d12e
Merge branch 'main' into main
AmariahAK 05c6c71
Merge branch 'main' into main
AmariahAK 47fee4b
Merge branch 'main' into main
AmariahAK 384c10a
Merge branch 'main' into main
AmariahAK 0eedf4b
Merge branch 'QwenLM:main' into main
AmariahAK 4ad0e11
fix(web-shell): address review comments for vision model picker encoding
atlarix-agent fd8e83a
test(web-shell): add edge-case tests for model encoding functions
atlarix-agent b7898e5
Merge branch 'main' into main
AmariahAK 722a952
Merge branch 'main' into main
AmariahAK f710b40
Merge branch 'main' into main
AmariahAK 7018f0d
Merge branch 'main' into main
AmariahAK a5ef400
Merge branch 'main' into main
AmariahAK 86d5a15
fix: PR #6236 follow-up — vision model encoding + fast model highlight
atlarix-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The
currentModelIdternary has no'fast'branch. WhenmodelDialogMode === 'fast', it falls through toundefined, andModelDialogfalls back toconnection.currentModel(the main chat model) — highlighting the wrong model in the fast picker.This PR added
currentVisionModel(great!) but missedcurrentFastModel. Consider adding it following the same derivation pattern.— qwen3.7-max via Qwen Code /review