Repository navigation
fix(core): Allow subagents to exit plan mode #6026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
doudouOUC
merged 4 commits into
QwenLM:main
from
doudouOUC:codex/fix-subagent-plan-mode-state
Jun 30, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b58176e
fix(core): allow subagents to exit plan mode
doudouOUC 9f8da75
fix(core): guard subagent AUTO cleanup under AUTO parent
doudouOUC 229a574
fix(core): read subagent approval mode from child config
doudouOUC 7fce620
test(core): cover subagent approval override state isolation
doudouOUC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 断言冗余
前面已经断言了
child.getApprovalMode() === DEFAULT,然后手动计算isPlanMode = (DEFAULT === PLAN)即false,再传入isPlanModeBlocked(false, ...)断言结果为false。这实际上只验证了isPlanModeBlocked(false, ...) === false这一纯函数行为,对子代理退出 plan mode 的路径验证在第一个 expect 已完成。考虑直接验证调度器层面的行为而非手动构造 boolean 传入纯函数。