ci(review): increase PR review timeout from 90 to 120 minutes - #5959
Merged
Conversation
Large PRs with extensive diffs across multiple packages can exceed the 85-minute effective review window (90 - 5 buffer). The recent run #28318973107 timed out on PR #5777 which touched acp-bridge, serve, config, and chrome-extension packages. Bump both the job timeout-minutes and the validation cap to 120 so the review agent has enough headroom for complex multi-package PRs.
Collaborator
|
Thanks for the PR! Template: the PR uses custom headings ( On direction: this is clearly aligned. Run #28318973107 timed out on a large PR and never reached the commenting phase — a concrete, real problem. Bumping the job timeout from 90 → 120 minutes is the straightforward fix. No CHANGELOG entry needed for internal CI config. On approach: the scope is exactly right. All six timeout-related Moving on to code review. 🔍 中文说明感谢贡献！ 模板：PR 使用了自定义标题（ 方向：明确对齐。Run #28318973107 在大 PR 上超时，未能进入评论阶段——这是一个真实、具体的问题。将任务超时从 90 分钟增加到 120 分钟是直接有效的修复。内部 CI 配置无需 CHANGELOG 条目。 方案：范围完全正确。工作流文件中所有 6 处 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Collaborator
Code ReviewIndependent proposal: to fix the review-agent timeout on large PRs, I'd increase the job-level Findings: nothing to flag. All six changes are straightforward numeric substitutions ( No security concerns, no logic changes, no AGENTS.md violations. The change is minimal and focused — exactly one file, one concern. Real-Scenario TestingN/A — this is a GitHub Actions workflow configuration change (timeout values). There is no user-visible behavior to exercise in tmux. Verification is limited to:
中文说明代码审查独立方案：为修复大 PR 上审查 Agent 超时的问题，应增加 审查结果：无问题。所有 6 处改动都是简单的数值替换（ 无安全问题、无逻辑变更、无 AGENTS.md 违规。改动最小且聚焦——单文件、单关注点。 真实场景测试不适用——这是 GitHub Actions 工作流配置变更（超时数值）。没有用户可见行为可在 tmux 中验证。验证仅限于：
— Qwen Code · qwen3.7-max |
Collaborator
|
This is exactly the kind of PR you want to see: a real problem (review agent timing out on large PRs), a minimal fix (bump the numbers), and nothing else. The diff is six lines of My independent proposal was identical — update all five timeout-related values in the workflow file. The PR does precisely that with no scope creep. If I had to maintain this in six months, I'd thank the author for keeping it clean. The only nit is the non-standard PR template headings, which is cosmetic and low-value to block on for a config bump. Approving. ✅ 中文说明这正是理想的 PR 形态：真实问题（审查 Agent 在大 PR 上超时）、最小修复（调大数值）、没有多余内容。Diff 是 6 行 我的独立方案完全相同——更新工作流文件中所有 5 处超时相关值。PR 精确执行，无范围蔓延。如果六个月后维护这段代码，会感谢作者保持了整洁。 唯一的瑕疵是 PR 模板标题不规范，但对于配置数值调整来说不值得拦截。 批准 ✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
approved these changes
Jun 28, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. Downgraded from Approve to Comment: CI still running.
This is a clean, mechanical timeout bump from 90 to 120 minutes across all 6 references in the workflow file. All values are consistent — input default, both job-level timeouts, shell fallback, validation cap, and error message are all updated in lockstep. No stale references to the old value remain. LGTM. ✅
— qwen3.7-max via Qwen Code /review
yiliang114
approved these changes
Jun 28, 2026
Collaborator
|
感谢各位的 review 反馈，已逐一审阅。 Triage 反馈确认：
独立验证结果：
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automated PR review workflow (
qwen-code-pr-review.yml) currently has a 90-minute job timeout with an 85-minute effective review window (90 − 5 min buffer). Run #28318973107 timed out on PR #5777, which touchedacp-bridge,cli/src/serve,cli/src/config, andchrome-extension— the review agent spent the full 85 minutes reading files and diffs but never reached the commenting phase.This PR bumps all timeout-related values from 90 → 120 minutes:
workflow_dispatchinput defaultreview-prjobtimeout-minutes-gt 120)resolvejobtimeout-minutesReviewer Test Plan