Skip to content

feat(web-shell): add mobile responsive view for TodoPanel #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jun 28, 2026
Merged

feat(web-shell): add mobile responsive view for TodoPanel #5948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/web-shell/client/components/panels/TodoPanel.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,29 @@
color: var(--muted-foreground);
}

.fullText {
display: inline;
}

.compactText {
display: none;
font-variant-numeric: tabular-nums;
}

@media (max-width: 599px) {

@qwen-code-ci-bot qwen-code-ci-bot Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] The 599px breakpoint is unique to this file. Every other responsive breakpoint in web-shell/client/components/ uses one of four values: 560px (DialogShell), 700px (StreamingStatus, StatusBar, Editor), 720px (StatusMessage, ContextUsageMessage, HelpDialog), or 760px (WebShellSidebar, WelcomeHeader, ToolApproval). At viewport widths 600–699px, the rest of the web-shell UI has already collapsed into its mobile layout, but TodoPanel still renders the full "Step 3 / 5" text — making it the last component to adapt.

Consider aligning with an existing breakpoint (e.g., 560px from DialogShell, which also handles narrow panel widths), or adding a brief comment explaining why 599px was chosen intentionally.

Suggested change
@media (max-width: 599px) {
@media (max-width: 560px) {

— qwen3.7-max via Qwen Code /review

.fullText {
display: none;
}

.compactText {
display: inline;
}

.summary {
padding: 6px 12px;
}
}

.detail {
position: absolute;
bottom: calc(100% + 8px);
Expand Down
7 changes: 6 additions & 1 deletion packages/web-shell/client/components/panels/TodoPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ export const TodoPanel = memo(function TodoPanel({
aria-hidden="true"
/>
<span className={styles.stepText}>
{t('todo.stepProgress', { current: stepIndex, total })}
<span className={styles.fullText}>
{t('todo.stepProgress', { current: stepIndex, total })}
</span>
<span className={styles.compactText}>
{t('todo.stepFraction', { current: stepIndex, total })}
</span>
</span>
</div>

Expand Down
2 changes: 2 additions & 0 deletions packages/web-shell/client/i18n.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,7 @@ const EN: Messages = {
'todo.moreAbove': (v) => `... ${v?.count ?? 0} earlier`,
'todo.showLess': 'Show less',
'todo.stepProgress': (v) => `Step ${v?.current ?? 0} / ${v?.total ?? 0}`,
'todo.stepFraction': (v) => `${v?.current ?? 0} / ${v?.total ?? 0}`,
'todo.title': 'Current tasks',
'chat.scrollToBottom': 'Scroll to bottom',
'userMessage.showMore': 'Show more',
Expand Down Expand Up @@ -2198,6 +2199,7 @@ const ZH: Messages = {
'todo.moreAbove': (v) => `... 前面还有 ${v?.count ?? 0} 项`,
'todo.showLess': '收起',
'todo.stepProgress': (v) => `第 ${v?.current ?? 0} / ${v?.total ?? 0} 步`,
'todo.stepFraction': (v) => `${v?.current ?? 0} / ${v?.total ?? 0}`,
'todo.title': '当前任务',
'chat.scrollToBottom': '回到底部',
'userMessage.showMore': '显示更多',
Expand Down
Loading