Skip to content

fix(test): raise timeout for cold-import suites to stop CI flake #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 1 commit into from
Jun 26, 2026
+14 −1
Merged

fix(test): raise timeout for cold-import suites to stop CI flake #5880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/core/src/config/config-session-env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ const baseParams: ConfigParameters = {
overrideExtensions: [],
};

// Each test re-imports config.js's full transitive module graph cold
// (afterEach calls vi.resetModules() so the module-level sessionEnvClaimed
// flag resets). That cold transform+evaluate runs several seconds and, under
// a contended CI runner, crosses the 5s default — a flaky timeout, not a hang.
// The reset is load-bearing for what these tests check, so give them headroom.
vi.setConfig({ testTimeout: 30_000 });

@doudouOUC doudouOUC Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] All 5 existing vi.setConfig call sites in packages/core set both testTimeout and hookTimeout. This file has non-trivial hooks (vi.resetModules() + env restoration in afterEach) that could theoretically exceed the default 10s hookTimeout under extreme CI contention. Consider adding hookTimeout for consistency:

Suggested change
vi.setConfig({ testTimeout: 30_000 });
vi.setConfig({ testTimeout: 30_000, hookTimeout: 30_000 });

— qwen3.7-max via Qwen Code /review


describe('Config sessionEnvClaimed guard', () => {
let originalEnv: string | undefined;

Expand Down
8 changes: 7 additions & 1 deletion packages/core/src/skills/skill-activation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,20 @@
*/

import * as path from 'node:path';
import { describe, expect, it } from 'vitest';
import { describe, expect, it, vi } from 'vitest';
import {
SkillActivationRegistry,
resolveProjectRelativePath,
splitConditionalSkills,
} from './skill-activation.js';
import type { SkillConfig } from './types.js';

// The integration tests below `await import('../core/coreToolScheduler.js')`
// just to reach one pure helper, but that drags in the whole scheduler module
// graph cold. The first such import runs a few seconds and, under a contended
// CI runner, crosses the 5s default — a flaky timeout, not a hang.
vi.setConfig({ testTimeout: 30_000 });

@doudouOUC doudouOUC Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] vi.setConfig({ testTimeout: 30_000 }) at module scope applies 30s to all 21 tests in this file, but only the 2 integration tests below (await import('../core/coreToolScheduler.js')) need the extra headroom. The other 19 are pure synchronous unit tests that should fail fast.

All 5 other vi.setConfig call sites in packages/core place it inside a describe block, not at module scope. Moving it into the integration describe block would match the established convention and correctly scope the timeout:

Suggested change
vi.setConfig({ testTimeout: 30_000 });
describe('extractToolFilePaths \u2192 SkillActivationRegistry integration', () => {
vi.setConfig({ testTimeout: 30_000 });

— qwen3.7-max via Qwen Code /review


function makeSkill(overrides: Partial<SkillConfig>): SkillConfig {
return {
name: overrides.name ?? 'test-skill',
Expand Down
Loading