fix(web-shell): reword the Chinese tool-group summary (执行了 → 调用了) - #5876
Conversation
The collapsed tool-group summary read "执行了 N 个工具", but in Chinese a tool is "调用" (invoked), not "执行" (executed); 执行 collocates with 操作/命令/任务. "工具调用" is also the established term elsewhere in the codebase. Switch the zh string to "调用了 N 个工具". The English "Ran N tools" is unchanged.
|
Thanks for the PR! Template looks good ✓ — all required sections present, bilingual, with a clear test plan. On direction: this is a clean i18n wording fix — changing On approach: the change is minimal and exactly right for the goal — one line, one locale key, no drive-by edits. The PR description honestly calls out the minor Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ — 所有必要章节齐全,中英双语,测试计划清晰。 方向:这是一个干净的中文 i18n 用词修正——把工具组摘要从 方案:改动极小且精准——一行代码、一个语言键、无顺手改动。PR 描述坦诚指出了 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Code ReviewOne file, one line, zero surprises. The change swaps
No blockers. No convention violations. Clean. Test ResultsFull web-shell suite after All 471 tests pass — matches the PR author's claim exactly. Tmux Real-Scenario TestingN/A — this is a web-shell browser UI locale string, not a CLI feature. The 中文说明代码审查一个文件、一行代码、零意外。改动将 ZH 语言包的
无阻塞项,无规范违反。干净。 测试结果
Tmux 真实场景测试不适用——这是 web-shell 浏览器端的语言包字符串,不是 CLI 功能。 — Qwen Code · qwen3.7-max |
|
This is exactly the kind of PR I want to see from the community — small, focused, well-reasoned, and honest about its own limitations. The PR author identified a genuine Chinese wording issue ( My independent proposal would have been identical: find Approving. ✅ 中文说明这正是社区贡献的理想范例——小范围、聚焦、有理有据,且对自身局限性坦诚。 PR 作者发现了一个真实的中文用词问题( 我的独立方案与之完全一致:找到 ZH 语言表中的 通过。✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
No issues found. Downgraded from Approve to Comment: CI still running. LGTM! ✅
— qwen3.7-max via Qwen Code /review
What this PR does
Rewords the collapsed tool-group summary in the Web Shell's Chinese locale from
执行了 N 个工具to调用了 N 个工具. The English locale (Ran N tools) is unchanged.Why it's needed
In Chinese a tool is 调用 (invoked/called), not 执行 (executed) —
执行collocates more naturally with 操作/命令/任务, while a tool/function is something you 调用. The codebase already uses 工具调用 as the established term for "tool call" (e.g. the CLI locale's{{count}} 个工具调用). The previous执行了 N 个工具read like a literal machine translation;调用了 N 个工具is more idiomatic.Reviewer Test Plan
How to verify
This is a single i18n display string (
toolGroup.summaryin theZHmessage table). In the Web Shell with the Chinese locale, run a turn that triggers tool calls; once the tool group collapses, the summary now reads调用了 N 个工具(e.g.调用了 3 个工具). The English locale still showsRan N tools.npm testinpackages/web-shell→ 471 passing.npm run buildinpackages/web-shell→ succeeds; the built bundle contains调用了 ${...} 个工具.Evidence (Before & After)
执行了 3 个工具调用了 3 个工具English is unchanged (
Ran 3 tools). This is a one-string wording swap with no layout or logic change, so there is no visual diff beyond the text itself.Tested on
A locale string is platform-independent; verified on macOS via web-shell unit tests + production build.
Environment (optional)
N/A — verified via
packages/web-shellunit tests andnpm run build.Risk & Scope
正在执行 …, so there is a minor 执行/调用 wording split between the in-progress and completed states; this PR intentionally scopes to the completed summary only.正在执行running-state string.Linked Issues
None.
中文说明
这个 PR 做了什么
把 Web Shell 中文语言包里折叠后的工具组摘要从
执行了 N 个工具改为调用了 N 个工具。英文(Ran N tools)保持不变。为什么需要
中文里工具是被调用的,不是被执行的——
执行更常搭配 操作/命令/任务,而工具/函数是「调用」。代码库里 "tool call" 的既有译法本就是工具调用(例如 CLI 语言包的{{count}} 个工具调用)。原来的执行了 N 个工具读着像直译,调用了 N 个工具更地道。验证方式
这是单条 i18n 文案(
ZH文案表里的toolGroup.summary)。在中文语言包下,跑一轮会触发工具调用的对话,工具组折叠后摘要显示调用了 N 个工具(如调用了 3 个工具);英文仍显示Ran N tools。packages/web-shell下npm test→ 471 通过。packages/web-shell下npm run build→ 成功,产物包含调用了 ${...} 个工具。改动前后
执行了 3 个工具调用了 3 个工具英文不变(
Ran 3 tools)。仅文案替换,无布局或逻辑改动。风险与范围
正在执行 …,因此进行中与完成态之间存在轻微的 执行/调用 用词不一致;本 PR 有意只改完成态摘要。正在执行进行中态文案。