-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(cli): add /model --vision for a fallback vision model #5778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e286ae2
feat(cli): add /model --vision for a fallback vision model
yiliang114 193ab67
Merge branch 'main' into feat/model-vision-fallback
yiliang114 9a5ff76
fix(cli): add vision model description translations
yiliang114 3c01111
feat(cli): warn on non-image-capable /model --vision pin; cover modal…
yiliang114 7625698
fix(cli): translate the non-image-capable vision model warning
yiliang114 14de333
fix(vision-bridge): stop showing the image transcription twice
yiliang114 512c288
fix(cli): register vision model i18n strings and cover /model --vision
yiliang114 19fc954
Merge branch 'main' into feat/model-vision-fallback
yiliang114 b1e4dac
refactor(vision-bridge): remove dead VisionBridgeResult.transcript field
yiliang114 bfd3715
test(cli): cover vision-model branches; dedupe fast/vision helpers
yiliang114 96bde28
test(cli): vision-mode coverage + register --vision completion i18n key
yiliang114 7841846
Merge branch 'main' into feat/model-vision-fallback
wenshao 6fc4d96
fix(core): exclude primary model from explicit vision bridge selection
yiliang114 741128e
chore(core): log vision bridge transcription for traceability
yiliang114 75b24fc
test: cover vision model helpers and vision-model dialog dispatch
yiliang114 05dddbc
fix(cli): render vision bridge notice as a dim tip, drop doubled marker
yiliang114 447a678
test(cli): assert VISION_NOTICE type for mid-turn vision bridge notice
yiliang114 998a4e6
test(cli): cover vision_notice classification and rendering
yiliang114 14168a6
Merge branch 'main' into feat/model-vision-fallback
yiliang114 5a45221
fix(vision): harden vision-bridge model selection + UX
yiliang114 1619e4e
fix(vision): fail-closed bridge routing, ambiguity guards, i18n, sett…
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.