-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(cli): default to virtualized terminal history #5738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8f5eb98
fix(cli): default to virtualized terminal history
ZevGit 738cac3
Merge branch 'main' into fix/cli-scroll-flicker
wenshao b35fef7
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit 604e733
fix(cli): remove redundant alternate screen exit handler
ZevGit cc5d436
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit 22f100f
Merge branch 'main' into fix/cli-scroll-flicker
wenshao 769e196
fix(cli): merge main into scroll-flicker branch, resolving useTermina…
qwen-code-dev-bot 8632a62
fix(cli): keep non-interactive output off VP mode
ZevGit 975d216
fix(cli): stabilize VP tests in CI environments
ZevGit 874fb6c
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit 50187da
test(cli): resolve SDK daemon source in vitest
ZevGit 81daecf
fix(cli): normalize CI env checks for VP mode
ZevGit e1cc1c4
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit ddc0c31
fix(cli): keep default VP mouse interactions enabled
ZevGit 6953ae4
Merge branch 'main' into fix/cli-scroll-flicker
ZevGit c4485e2
fix(cli): resolve merge conflicts with main for virtualized terminal …
qwen-code-dev-bot 999a609
Merge branch 'main' into fix/cli-scroll-flicker
wenshao 9e0919b
Merge branch 'main' into fix/cli-scroll-flicker
wenshao f4cdecc
fix(cli): align VP mouse behavior with runtime state
ZevGit cc24b0a
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit 0c9df2b
fix(cli): stabilize virtual viewport runtime state
ZevGit a22120a
test(cli): cover virtual viewport fallbacks
ZevGit ad92da5
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit cef51a6
docs(cli): clarify virtual viewport requirements
ZevGit 66a1499
Merge remote-tracking branch 'upstream/main' into fix/cli-scroll-flicker
ZevGit 2a097de
Merge branch 'main' into fix/cli-scroll-flicker
ZevGit d18f38a
Merge upstream/main into fix/cli-scroll-flicker
ZevGit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This default flip leaves
docs/design/ctrl-o-detail-expand/design.mdinconsistent with the shipped architecture: its current-state sections still call native scrollback/<Static>the default and point to the old rawgemini.tsxsettings gate. Update those passages to describe VP/alternate-screen as the default interactive path, the explicit opt-out/screen-reader/non-interactive exceptions, and the startup decision instartInteractiveUI.tsx.— Codex $qreview via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0c9df2b. The Ctrl+O design now describes VP/root alternate-screen as the default interactive path, the explicit opt-out, screen-reader, CI, non-TTY, and TERM=dumb fallbacks, and the single startup decision shared by startInteractiveUI and AppContainer. The transcript enter/exit sections and implementation references were updated to match the current architecture.