Skip to content

fix(test): make ACP set_config_option test use a deterministic openai provider model #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jun 23, 2026
Merged

fix(test): make ACP set_config_option test use a deterministic openai provider model #5728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions integration-tests/cli/acp-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,31 @@ function setupAcpTest(

it('supports session/set_config_option for mode and model', async () => {
const rig = new TestRig();
rig.setup('acp set config option');
// Inject a deterministic openai provider model so `availableModels` always
// contains a settable openai entry. The previous version relied on the
// env-driven OPENAI_MODEL being captured as a runtime-model snapshot and
// enumerated, which is environment-sensitive and flaked in CI (the openai
// model could be absent from `availableModels`, failing the assertion
// below). A registry model configured via `modelProviders` is always
// enumerated and switchable without inference, making this test
// deterministic regardless of how the ambient openai credentials resolve.
rig.setup('acp set config option', {
settings: {
modelProviders: {
openai: {
protocol: 'openai',
models: [
{
id: 'e2e-set-config-option-model',
name: 'E2E Set Config Option Model',
baseUrl: 'https://api.openai.com/v1',
envKey: 'OPENAI_API_KEY',
},
],
},
},
},
});

const { sendRequest, cleanup, stderr } = setupAcpTest(rig);

Expand Down Expand Up @@ -528,9 +552,10 @@ function setupAcpTest(
expect(modelOption!.currentValue).toBeTruthy();

// Test: Set model using set_config_option
// Use openai model to avoid auth issues
// Target the deterministic openai provider model injected via settings
// above (avoids auth issues and is always present in `availableModels`).
const openaiModel = newSession.models.availableModels.find((model) =>
model.modelId.includes('openai'),
model.modelId.includes('e2e-set-config-option-model'),
);
expect(openaiModel).toBeDefined();

Expand Down
Loading