Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions packages/cli/src/acp-integration/service/filesystem.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,114 @@ describe('AcpFileSystemService', () => {
expect(client.readTextFile).not.toHaveBeenCalled();
});
});

describe('writeTextFile', () => {
it('writes through ACP with the session id', async () => {
const client = {
writeTextFile: vi.fn().mockResolvedValue(undefined),
} as unknown as AgentSideConnection;

const svc = new AcpFileSystemService(
client,
'session-4',
{ readTextFile: true, writeTextFile: true },
createFallback(),
);

const result = await svc.writeTextFile({
path: '/some/file.txt',
content: 'hello',
});

expect(result).toEqual({ _meta: undefined });
expect(client.writeTextFile).toHaveBeenCalledWith({
path: '/some/file.txt',
content: 'hello',
sessionId: 'session-4',
});
});

it('preserves a UTF-8 BOM without duplicating an existing marker', async () => {
const client = {
writeTextFile: vi.fn().mockResolvedValue(undefined),
} as unknown as AgentSideConnection;

const svc = new AcpFileSystemService(
client,
'session-5',
{ readTextFile: true, writeTextFile: true },
createFallback(),
);

await svc.writeTextFile({
path: '/some/file.txt',
content: '\uFEFFHello',
_meta: { bom: true },
});

expect(client.writeTextFile).toHaveBeenCalledWith({
path: '/some/file.txt',
content: '\uFEFFHello',
_meta: { bom: true },
sessionId: 'session-5',
});
});

it('adds a UTF-8 BOM marker when requested and missing', async () => {
const client = {
writeTextFile: vi.fn().mockResolvedValue(undefined),
} as unknown as AgentSideConnection;

const svc = new AcpFileSystemService(
client,
'session-6',
{ readTextFile: true, writeTextFile: true },
createFallback(),
);

await svc.writeTextFile({
path: '/some/file.txt',
content: 'Hello',
_meta: { bom: true },
});

expect(client.writeTextFile).toHaveBeenCalledWith({
path: '/some/file.txt',
content: '\uFEFFHello',
_meta: { bom: true },
sessionId: 'session-6',
});
});

it('uses fallback when writeTextFile capability is disabled', async () => {
const client = {
writeTextFile: vi.fn(),
} as unknown as AgentSideConnection;
const fallback = createFallback();
(fallback.writeTextFile as ReturnType<typeof vi.fn>).mockResolvedValue({
_meta: { bom: true },
});

const svc = new AcpFileSystemService(
client,
'session-7',
{ readTextFile: true, writeTextFile: false },
fallback,
);

const result = await svc.writeTextFile({
path: '/some/file.txt',
content: '\uFEFFHello',
_meta: { bom: true },
});

expect(result).toEqual({ _meta: { bom: true } });
expect(fallback.writeTextFile).toHaveBeenCalledWith({
path: '/some/file.txt',
content: '\uFEFFHello',
_meta: { bom: true },
});
expect(client.writeTextFile).not.toHaveBeenCalled();
});
});
});
7 changes: 4 additions & 3 deletions packages/cli/src/acp-integration/service/filesystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,10 @@ export class AcpFileSystemService implements FileSystemService {
return this.fallback.writeTextFile(params);
}

const finalContent = params._meta?.['bom']
? '\uFEFF' + params.content
: params.content;
const finalContent =
params._meta?.['bom'] && params.content.charCodeAt(0) !== 0xfeff
? '\uFEFF' + params.content
: params.content;

await this.connection.writeTextFile({
...params,
Expand Down
Loading