Skip to content

ci(audio-capture): cross-compile darwin-x64 prebuild on arm64, drop macos-13 runner #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqqys merged 2 commits into from
Jun 22, 2026
Merged

ci(audio-capture): cross-compile darwin-x64 prebuild on arm64, drop macos-13 runner #5643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24fcc08
ci(audio-capture): cross-compile darwin-x64 prebuild on arm64 runner
qqqys Jun 22, 2026
a95748b
Merge branch 'main' into ci/audio-prebuild-cross-compile
wenshao Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/audio-capture-prebuilds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@ jobs:
fail-fast: false
matrix:
include:
# arm64 runner; also cross-compiles the x64 slice (see Build step) to
# avoid the scarce macos-13 Intel runner that queues 20+ min (#5642).
- os: 'macos-14'
runner: 'macos-14'
arch: 'arm64'
- os: 'macos-13'
runner: 'macos-13'
arch: 'x64'
- os: 'ubuntu-latest'
runner: 'ubuntu-latest'
arch: 'x64'
Expand All @@ -59,7 +58,14 @@ jobs:
- name: 'Install build deps'
run: 'npm install --no-workspaces --ignore-scripts --no-audit --no-fund'
- name: 'Build prebuild'
run: 'npm run prebuildify'
shell: 'bash'

@wenshao wenshao Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] After this change the single macos-14 matrix entry produces both darwin-arm64/ and darwin-x64/ prebuilds, but the upload-artifact name downstream (line 72) is prebuilds-${{ matrix.os }}-${{ matrix.arch }}, which evaluates to prebuilds-macos-14-arm64. The automated pipeline is unaffected (the collect job uses pattern: 'prebuilds-*' with merge-multiple: true), but a maintainer downloading that artifact to debug a CI failure would be surprised to find x64 binaries inside an arm64-named archive.

Consider either:

  1. Adding a matrix variable (e.g., artifact_suffix: 'arm64+x64') and using name: 'prebuilds-${{ matrix.os }}-${{ matrix.artifact_suffix || matrix.arch }}', or
  2. Appending a +x64 suffix conditionally for the macOS entry.

— qwen3.7-max via Qwen Code /review

run: |
npm run prebuildify
# Cross-compile the Intel (x64) slice on this arm64 runner instead of
# a separate macos-13 runner (frameworks are universal). See #5642.
if [ "$RUNNER_OS" = 'macOS' ]; then
npm run prebuildify -- --arch x64
fi
- name: 'Upload prebuild'
uses: 'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a' # v7.0.1
with:
Expand Down
Loading