Skip to content

fix(cli): allow double dots in update archives #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jun 21, 2026
Merged

fix(cli): allow double dots in update archives #5521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/cli/src/utils/standalone-update.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
ensureBinWrapper,
ensurePathInShellRc,
performStandaloneUpdate,
isSafeTarEntryPath,
} from './standalone-update.js';

describe('standalone-update', () => {
Expand Down Expand Up @@ -260,6 +261,25 @@ describe('standalone-update', () => {
});
});

describe('isSafeTarEntryPath', () => {
it('allows double dots inside a filename segment', () => {
expect(isSafeTarEntryPath('qwen-code/release..notes.md')).toBe(true);
expect(isSafeTarEntryPath('qwen-code/node/lib/foo..bar')).toBe(true);
expect(isSafeTarEntryPath('qwen-code/.../file.txt')).toBe(true);
});

it('rejects parent-directory segments and absolute paths', () => {
expect(isSafeTarEntryPath('../qwen-code/manifest.json')).toBe(false);
expect(isSafeTarEntryPath('qwen-code/../manifest.json')).toBe(false);
expect(isSafeTarEntryPath('qwen-code\\..\\manifest.json')).toBe(false);
expect(isSafeTarEntryPath('/tmp/qwen-code/manifest.json')).toBe(false);
expect(isSafeTarEntryPath('C:\\tmp\\qwen-code\\manifest.json')).toBe(
false,
);
expect(isSafeTarEntryPath('')).toBe(false);
});
});

describe('rollbackStandaloneUpdate — concurrent lock protection', () => {
it('returns error when an active update holds the lock', () => {
const standaloneDir = path.join(tempDir, 'qwen-code');
Expand Down
10 changes: 9 additions & 1 deletion packages/cli/src/utils/standalone-update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,14 @@ function validateExtractedPaths(resolvedDest: string): void {
}
}

export function isSafeTarEntryPath(entryPath: string): boolean {
if (entryPath.length === 0) return false;
if (path.posix.isAbsolute(entryPath) || path.win32.isAbsolute(entryPath)) {
return false;
}
return !entryPath.split(/[\\/]+/).includes('..');
}

async function extractArchive(
archivePath: string,
destDir: string,
Expand Down Expand Up @@ -250,7 +258,7 @@ async function extractArchive(
cwd: destDir,
preservePaths: false,
filter: (p, entry) => {
if (p.startsWith('/') || p.includes('..')) return false;
if (!isSafeTarEntryPath(p)) return false;
if (
'type' in entry &&
entry.type === 'SymbolicLink' &&
Expand Down
Loading