Skip to content

fix(cli): stabilize extension list spacing #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jun 20, 2026
Merged

fix(cli): stabilize extension list spacing #5445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/cli/src/ui/components/extensions/steps/ExtensionListStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,11 @@ export const ExtensionListStep = ({
: [];

return (
<Box key={extension.name} flexDirection="column" marginBottom={descLines.length > 0 ? 1 : 0}>
<Box
key={extension.name}
flexDirection="column"
marginBottom={descLines.length > 0 ? 1 : 0}
>
<Box alignItems="center">
<Box minWidth={2} flexShrink={0}>
<Text color={isSelected ? theme.text.accent : theme.text.primary}>
Expand All @@ -189,15 +193,17 @@ export const ExtensionListStep = ({
{getExtensionDisplayName(extension, locale)}
</Text>
</Box>
<Box width={maxStatusWidth + 4} flexShrink={0}>
<Text color={activeColor}> ({activeString})</Text>
<Box marginLeft={2} width={maxStatusWidth + 2} flexShrink={0}>

@wenshao wenshao Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] The total horizontal footprint of the status column (marginLeft(2) + width(maxStatusWidth + 2) = maxStatusWidth + 4) is implicitly coupled to the + 4 in fixedWidth on line 170. Before this PR, the + 4 lived in one place (width={maxStatusWidth + 4}), making the correspondence easy to spot. Now it's split across two props on a different line from fixedWidth, so a future edit to the margin or width padding could silently break the description-width calculation.

Consider extracting a shared named constant:

Suggested change
<Box marginLeft={2} width={maxStatusWidth + 2} flexShrink={0}>
<Box marginLeft={statusGap} width={maxStatusWidth + statusGap} flexShrink={0}>

…and on line 170:

const statusGap = 2;
const fixedWidth = 2 + maxNameWidth + statusGap + maxStatusWidth + statusGap + 15;

This keeps the two sites in sync and makes the intent self-documenting.

— qwen3.7-max via Qwen Code /review

<Text color={activeColor}>({activeString})</Text>
</Box>
{stateText && <Text color={stateColor}>[{stateText}]</Text>}
</Box>
{descLines.length > 0 && (
<Box paddingLeft={2} flexDirection="column">
{descLines.map((line, i) => (
<Text key={i} color={theme.text.secondary}>{line}</Text>
<Text key={i} color={theme.text.secondary}>
{line}
</Text>
))}
</Box>
)}
Expand Down
Loading