Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/core/src/memory/const.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { vi, describe, it, expect } from 'vitest';
import { vi, describe, it, expect, beforeEach } from 'vitest';
import {
AGENT_CONTEXT_FILENAME,
DEFAULT_CONTEXT_FILENAME,
setGeminiMdFilename,
getCurrentGeminiMdFilename,
getAllGeminiMdFilenames,
} from './const.js';
import {
setGeminiMdFilename as setToolGeminiMdFilename,
getCurrentGeminiMdFilename as getToolCurrentGeminiMdFilename,
getAllGeminiMdFilenames as getToolAllGeminiMdFilenames,
} from '../tools/memory-config.js';

// Mock dependencies
vi.mock(import('node:fs/promises'), async (importOriginal) => {
Expand All @@ -24,6 +31,10 @@ vi.mock(import('node:fs/promises'), async (importOriginal) => {
vi.mock('os');

describe('setGeminiMdFilename', () => {
beforeEach(() => {
setGeminiMdFilename([DEFAULT_CONTEXT_FILENAME, AGENT_CONTEXT_FILENAME]);
});

it('should update currentGeminiMdFilename when a valid new name is provided', () => {
const newName = 'CUSTOM_CONTEXT.md';
setGeminiMdFilename(newName);
Expand All @@ -45,4 +56,14 @@ describe('setGeminiMdFilename', () => {
expect(getCurrentGeminiMdFilename()).toBe('CUSTOM_CONTEXT.md');
expect(getAllGeminiMdFilenames()).toEqual(newNames);
});

it('shares filename state with the legacy tools memory config entrypoint', () => {
setGeminiMdFilename(['CUSTOM_CONTEXT.md', 'AGENTS.md']);
expect(getToolCurrentGeminiMdFilename()).toBe('CUSTOM_CONTEXT.md');
expect(getToolAllGeminiMdFilenames()).toEqual(getAllGeminiMdFilenames());

setToolGeminiMdFilename('LEGACY_CONTEXT.md');
expect(getCurrentGeminiMdFilename()).toBe('LEGACY_CONTEXT.md');
expect(getAllGeminiMdFilenames()).toEqual(['LEGACY_CONTEXT.md']);
});
});
42 changes: 7 additions & 35 deletions packages/core/src/tools/memory-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,39 +9,11 @@
* Extracted from memoryTool.ts to avoid loading the full tool module
* when only the filename configuration is needed.
*/

export const DEFAULT_CONTEXT_FILENAME = 'QWEN.md';
export const AGENT_CONTEXT_FILENAME = 'AGENTS.md';
export const MEMORY_SECTION_HEADER = '## Qwen Added Memories';

// This variable will hold the currently configured filename for context files.
// It defaults to include both QWEN.md and AGENTS.md but can be overridden by setGeminiMdFilename.
// QWEN.md is first to maintain backward compatibility (used by /init command and save_memory tool).
let currentGeminiMdFilename: string | string[] = [
DEFAULT_CONTEXT_FILENAME,
export {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] The JSDoc above this export says "Extracted from memoryTool.ts to avoid loading the full tool module when only the filename configuration is needed" — but the file is now a pure re-export barrel with no logic of its own. Additionally, grep shows zero production-code consumers of this module (all imports already use memory/const.js directly). Consider either updating the comment to reflect the barrel role (e.g., "Re-export barrel for backward compatibility. Canonical definitions live in ../memory/const.ts.") or removing the file entirely in a follow-up if no external consumers depend on it.

— qwen3.7-max via Qwen Code /review

AGENT_CONTEXT_FILENAME,
];

export function setGeminiMdFilename(newFilename: string | string[]): void {
if (Array.isArray(newFilename)) {
if (newFilename.length > 0) {
currentGeminiMdFilename = newFilename.map((name) => name.trim());
}
} else if (newFilename && newFilename.trim() !== '') {
currentGeminiMdFilename = newFilename.trim();
}
}

export function getCurrentGeminiMdFilename(): string {
if (Array.isArray(currentGeminiMdFilename)) {
return currentGeminiMdFilename[0];
}
return currentGeminiMdFilename;
}

export function getAllGeminiMdFilenames(): string[] {
if (Array.isArray(currentGeminiMdFilename)) {
return currentGeminiMdFilename;
}
return [currentGeminiMdFilename];
}
DEFAULT_CONTEXT_FILENAME,
getAllGeminiMdFilenames,
getCurrentGeminiMdFilename,
MEMORY_SECTION_HEADER,
setGeminiMdFilename,
} from '../memory/const.js';
Loading