Skip to content

fix(cli): gate cron scheduler startup on config initialization (#5022) #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jun 19, 2026
Merged

fix(cli): gate cron scheduler startup on config initialization (#5022) #5230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/ui/AppContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,11 +943,11 @@ describe('AppContainer State Management', () => {

describe('Cancel Handler (issue #3204)', () => {
// The cancel handler is wired through useGeminiStream's onCancelSubmit
// arg (positional index 14 — see the useGeminiStream call site in
// arg (positional index 15 — see the useGeminiStream call site in
// AppContainer.tsx). We capture it via mockImplementation so a future
// signature change surfaces as a clear test failure rather than silently
// grabbing the wrong callback.
const ON_CANCEL_SUBMIT_ARG_INDEX = 14;
const ON_CANCEL_SUBMIT_ARG_INDEX = 15;
type CapturedCancelSubmit = (info?: {
pendingItem: HistoryItemWithoutId | null;
lastTurnUserItem: { id: number; text: string } | null;
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/ui/AppContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,6 +1483,7 @@ export const AppContainer = (props: AppContainerProps) => {
historyManager.history,
historyManager.addItem,
config,
isConfigInitialized,
settings,
onDebugMessage,
handleSlashCommand,
Expand Down
Loading
Loading