Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(plan-gate): isolate gate agent AbortSignal from parent signal chain #5185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(plan-gate): isolate gate agent AbortSignal from parent signal chain #5185
Changes from 3 commits
ef3d832f36201c9e8662a6725e00579d239b1baf06File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during execution. Matches the actual isolation behavior.
fully signal-isolated with its own timeout, so parent-side aborts
(typically transient) should not short-circuit retries. The caller
discards the result if the parent is truly gone.
early if the parent signal aborts during the 1s wait. Prevents
wasted shutdown time on genuine cancellation.
the 5-minute ceiling matches runConfig.max_time_minutes.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
_parentSignalis accepted but never observed. If the parent aborts during gate agent execution, there's zero log output connecting the parent abort to the gate agent's continued execution. For debugging "I cancelled but it kept going" reports, oncall needs a breadcrumb.Consider adding a one-time listener before the AbortController:
— qwen3.7-max via Qwen Code /review
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Timeout errors are retried identically to transient errors. When the gate agent's 5-minute timeout fires (
gateReviewAgents.ts:165), the error propagates here and the retry loop launches another 5-minute attempt. WithMAX_AGENT_RETRIES=3, worst case = ~15 minutes of blocked waiting.A timeout signals the operation is too expensive — retrying it at the same budget defeats the safety net. Consider distinguishing timeout errors:
— qwen3.7-max via Qwen Code /review