Repository navigation
feat(tui): remove tool group borders and collapse completed tool results #5003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
895829b
b4e2d9b
6dcf188
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -670,10 +670,12 @@ export const ToolMessage: React.FC<ToolMessageProps> = ({ | |||||
| // Use the custom hook to determine the display type | ||||||
| const displayRenderer = useResultDisplayRenderer(resultDisplay); | ||||||
| const { compactMode } = useCompactMode(); | ||||||
| const effectiveDisplayRenderer = | ||||||
| !compactMode || forceShowResult | ||||||
| ? displayRenderer | ||||||
| : { type: 'none' as const }; | ||||||
|
|
||||||
| const isCompleted = status === ToolCallStatus.Success; | ||||||
| const shouldCollapse = compactMode && isCompleted && !forceShowResult; | ||||||
| const effectiveDisplayRenderer = shouldCollapse | ||||||
| ? { type: 'none' as const } | ||||||
| : displayRenderer; | ||||||
|
|
||||||
| return ( | ||||||
| <Box paddingX={1} paddingY={0} flexDirection="column"> | ||||||
|
|
@@ -780,6 +782,7 @@ const ToolInfo: React.FC<ToolInfo> = ({ | |||||
| status, | ||||||
| emphasis, | ||||||
| }) => { | ||||||
| const { compactMode } = useCompactMode(); | ||||||
| const nameColor = React.useMemo<string>(() => { | ||||||
| switch (emphasis) { | ||||||
| case 'high': | ||||||
|
|
@@ -794,13 +797,15 @@ const ToolInfo: React.FC<ToolInfo> = ({ | |||||
| } | ||||||
| } | ||||||
| }, [emphasis]); | ||||||
| const isDim = compactMode && status === ToolCallStatus.Success; | ||||||
| return ( | ||||||
|
chiga0 marked this conversation as resolved.
Resolved
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion]
Suggested change
This requires threading — qwen3.7-max via Qwen Code /review |
||||||
| <Box flexGrow={1}> | ||||||
| <Text | ||||||
| wrap="truncate-end" | ||||||
| strikethrough={status === ToolCallStatus.Canceled} | ||||||
| dimColor={isDim} | ||||||
| > | ||||||
| <Text color={nameColor} bold> | ||||||
| <Text color={nameColor} bold={!isDim}> | ||||||
| {localizeToolDisplayName(name)} | ||||||
| </Text>{' '} | ||||||
| <Text color={theme.text.secondary}>{description}</Text> | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.