Repository navigation
fix(daemon): bind QWEN_CODE_SESSION_ID to the current session via AsyncLocalStorage #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Qwen | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { AsyncLocalStorage } from 'node:async_hooks'; | ||
|
|
||
| /** | ||
| * Per-async-context session ID, mirroring {@link promptIdContext}. | ||
| * | ||
| * `QWEN_CODE_SESSION_ID` historically lived only in `process.env`, which is | ||
| * a single process-global slot. That is fine for the interactive CLI (one | ||
| * session per process, switched via `Config.startNewSession()`), but breaks | ||
| * in daemon mode where one process hosts many concurrent sessions: only the | ||
| * first `Config` ever claims the env slot (see `sessionEnvClaimed` in | ||
| * config.ts), so shells spawned by every later session would read a stale | ||
| * session ID. | ||
| * | ||
| * Daemon-style hosts should wrap each session's execution entry points in | ||
| * `sessionIdContext.run(sessionId, ...)`. `getShellContextEnvVars()` prefers | ||
| * this context over `process.env`, falling back to the env var so the | ||
| * single-session CLI behavior is unchanged. | ||
| */ | ||
| export const sessionIdContext = new AsyncLocalStorage<string>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] 当
sessionIdContext.getStore()为undefined时,代码静默回退到process.env— 零诊断输出。如果有任何未来代码路径遗漏了 ALS 包裹,错误 session ID 会毫无预警地传播,生产环境极难排查。建议在 daemon 模式下,ALS 为空时加一条 debug 级别日志。— DeepSeek/deepseek-v4-pro via Qwen Code /review