Skip to content

fix(core): give complete intentional-sleep guidance on first rejection for sleep chains #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanzhenxin merged 1 commit into from
Jun 10, 2026
Merged

fix(core): give complete intentional-sleep guidance on first rejection for sleep chains #4948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/core/src/tools/shell.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,15 @@ describe('ShellTool', () => {
expect(error).toBeNull();
});

it('should not suggest the intentional sleep comment for sleep chains', async () => {
it('should guide model to split and use intentional-sleep for sleep chains', async () => {
const error = shellTool.validateToolParams({
command: 'sleep 5 && echo ok',
is_background: false,
});

expect(error).toContain(
'intentional-sleep escape hatch only applies to standalone sleep commands',
);
expect(error).not.toContain('# intentional-sleep:');
expect(error).toContain('Split into two calls');
expect(error).toContain('intentional-sleep:');
expect(error).toContain('reason');
});

it('should throw an error for a relative directory path', async () => {
Expand Down
6 changes: 2 additions & 4 deletions packages/core/src/tools/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4361,16 +4361,14 @@ export class ShellTool extends BaseDeclarativeTool<
// `-c` script. This matches every other sensitive check in this file
// (directory, read-only, command-root extraction, etc.).
if (!params.is_background) {
const sleepPattern = detectBlockedSleepPatternDetails(
stripShellWrapper(params.command),
);
const sleepPattern = detectBlockedSleepPatternDetails(strippedCommand);
if (sleepPattern !== null) {
const intentionalSleepGuidance =
sleepPattern.intentionalSleepRejection ??
(sleepPattern.isStandalone
? 'If you genuinely need a standalone delay (rate limiting, deliberate pacing), ' +
'add a trailing comment like `# intentional-sleep: wait for MCP rate limit reset` (up to 10 minutes).'
: 'The intentional-sleep escape hatch only applies to standalone sleep commands; split follow-up commands into a separate invocation.');
: 'Split into two calls: first `sleep N # intentional-sleep: <reason>` (standalone), then the follow-up command.');
return (
`Blocked: ${sleepPattern.description}. ` +
'Run blocking commands in the background with is_background: true. ' +
Expand Down
Loading