-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(core): microcompact hook continuations #4840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ef7d673
fix(core): microcompact hook continuations
qqqys 1d97164
test(core): cover hook microcompaction edge cases
qqqys b5b1fc3
test(core): cover hook checkpoint fallback
qqqys 5f9310d
chore(core): refresh hook microcompaction checks
qqqys f8a33cb
fix(core): keep hook microcompaction cleanup best-effort
qqqys 3fb72f8
test(core): cover hook microcompaction checkpoint state
qqqys 633b31a
test(core): cover hook microcompaction review cases
qqqys 737ac01
fix(core): retain hook checkpoint after microcompaction failure
qqqys 55f4a43
fix(core): clarify hook microcompaction comment
qqqys 0e104e1
fix(ci): normalize dev launcher path assertions
qqqys 92546b8
fix(core): preserve hook checkpoint on cron no-op
qqqys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This test covers the happy path (pre-set stale timestamp → trigger fires → cleanup runs), but several important paths are untested:
??=initialization: whenlastHookMicrocompactionTimestampisnullandlastApiCompletionTimestampis an old value, the Hook should inherit that timestamp and potentially trigger. This is the most logic-dense line in the change.lastHookMicrocompactionTimestamp = Date.now()(recent), send a Hook message, and assertsetHistoryis NOT called — guards against unconditional microcompaction on every Hook.null→ should useDate.now()and NOT trigger.lastHookMicrocompactionTimestampis updated to a recent value.Adding at minimum the negative test and the
??=init test would significantly strengthen coverage for the subtle parts of this change.— qwen3.7-max via Qwen Code /review