-
Notifications
You must be signed in to change notification settings - Fork 3.1k
ci(triage): Fix Qwen triage workflow prompt #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7c5b9b8
41c952e
a142c96
97716c6
3e258f1
333d131
46bc432
762e064
94c5700
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,15 +1,14 @@ | ||||||||||||||
| --- | ||||||||||||||
| name: triage | ||||||||||||||
| description: Gatekeep and review GitHub issues and pull requests for Qwen Code maintainers. Use for GitHub Action issue triage, PR admission checks, product-direction review, KISS-focused PR review, and staged bilingual GitHub comments. | ||||||||||||||
| argument-hint: '<issue|pr> <number> [--repo owner/repo]' | ||||||||||||||
| argument-hint: '<number> [--repo owner/repo]' | ||||||||||||||
| allowedTools: | ||||||||||||||
| - run_shell_command | ||||||||||||||
| - read_file | ||||||||||||||
| - read_many_files | ||||||||||||||
| - grep_search | ||||||||||||||
| - glob | ||||||||||||||
| - write_file | ||||||||||||||
| - task | ||||||||||||||
| - agent | ||||||||||||||
| - enter_worktree | ||||||||||||||
| - exit_worktree | ||||||||||||||
| --- | ||||||||||||||
|
|
@@ -34,14 +33,21 @@ gh label list --repo "$REPO" --limit 200 | |||||||||||||
| ## Rules | ||||||||||||||
|
|
||||||||||||||
| - Untrusted input: never interpolate issue/PR text into shell | ||||||||||||||
| - Labels: apply existing only, never create | ||||||||||||||
| - Comments: always `--body-file` (except short hardcoded verdicts in `gh pr review --approve` / `--request-changes`) | ||||||||||||||
| - Labels: apply existing only, never create. Do not touch process labels (`welcome-pr`, `maintainer`, `help wanted`, `good first issue`) | ||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] The old prompt had an explicit prohibition: "Never close, merge, approve, assign, or remove labels." The new SKILL.md correctly drops "never approve" (Stage 3 calls Consider adding after the Labels rule: - Never merge or assign. Only apply labels, post comments, and approve/request-changes as shown in the workflow templates.— qwen3.7-max via Qwen Code /review |
||||||||||||||
| - Comments: read body from file. Use `--body-file FILE` for `gh issue/pr comment`, | ||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] The Comments rule covers The old rule also had an explicit exception for short hardcoded verdicts in
Suggested change
— qwen3.7-max via Qwen Code /review |
||||||||||||||
| or `gh api -F body=@FILE` when the response ID is needed. Never `--body @FILE` | ||||||||||||||
| or `gh api -f body=@FILE` — those post the path literally. | ||||||||||||||
| - Drafts: skip | ||||||||||||||
|
|
||||||||||||||
| ## Duplicate Guard | ||||||||||||||
|
|
||||||||||||||
| - Unattended (CI env set) + prior `<!-- qwen-triage stage=N -->` marker in comments: exit | ||||||||||||||
| - Explicit `/triage`: run all stages, update prior comments in place | ||||||||||||||
| - Unattended CI events (`GITHUB_EVENT_NAME=issues` or | ||||||||||||||
|
yiliang114 marked this conversation as resolved.
|
||||||||||||||
| `pull_request_target`) + prior `<!-- qwen-triage stage=N -->` marker in | ||||||||||||||
| comments: exit | ||||||||||||||
| - Explicit reruns (`GITHUB_EVENT_NAME=issue_comment` or `workflow_dispatch`): | ||||||||||||||
| run all stages, update prior comments in place | ||||||||||||||
| - Local invocation (no `GITHUB_EVENT_NAME`): run all stages, update prior | ||||||||||||||
| comments in place | ||||||||||||||
|
|
||||||||||||||
| Every posted comment must include an invisible marker: `<!-- qwen-triage stage=N -->` where N is the stage number. The guard matches against this marker, not comment headings. | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.