Repository navigation
fix(core): preserve non-ASCII git paths in file crawler #4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kkhomej33-netizen
wants to merge
1
commit into
QwenLM:main
from
kkhomej33-netizen:codex/fix-git-quote-path
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
expect.arrayContaining(['-c', 'core.quotePath=false'])checks that both strings exist somewhere in the args array but does not verify they are adjacent. SincewithSafeGitConfigalready produces multiple-centries, the'-c'match is trivially satisfied by an unrelated entry. A bug that placedcore.quotePath=falsewithout a preceding-cwould go undetected.Consider verifying adjacency:
Note: the integration test above (real git, real non-ASCII file) would catch a positional regression, so this is low-risk in practice.
— qwen3.7-max via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point. Updated the mock assertion to verify that
core.quotePath=falseis immediately preceded by-c, while keeping the real Git regression test for the end-to-end behavior. Verified locally withcd packages/core && npx vitest run src/utils/filesearch/crawler.test.ts(46 tests passed).