fix(core): honor runtime output dir for auto memory

[he-yufeng]

Summary

• Fixes Auto memory storage doesn't respect runtimeOutputDir configuration #4709.
• Make managed auto-memory default to Storage.getRuntimeBaseDir() so runtimeOutputDir / QWEN_RUNTIME_DIR move the per-project memory tree with other runtime output.
• Keep QWEN_CODE_MEMORY_BASE_DIR as the explicit override and cover both path priorities in regression tests.

Verified

• npm run test --workspace=packages/core -- src/memory/store.test.ts
• npm run typecheck --workspace=packages/core
• npx eslint packages/core/src/memory/paths.ts packages/core/src/memory/store.test.ts
• git diff --check

[wenshao]

test

[wenshao]

[Critical] _autoMemoryRootCache cross-session contamination in daemon mode — paths.ts:99

_autoMemoryRootCache is keyed only by projectRoot, but the cached value depends on getMemoryBaseDir() → Storage.getRuntimeBaseDir(), which varies per AsyncLocalStorage context (set by runWithRuntimeBaseDir per session in daemon mode). clearAutoMemoryRootCache() is never called in production code.

In daemon mode, when two concurrent sessions have different runtimeOutputDir for the same project root, the first session to call getAutoMemoryRoot() caches its resolved path. The second session silently reads/writes memory in the wrong directory. This also affects isAutoMemPath permission checks in write/edit/read tools.

const _autoMemoryRootCache = new Map<string, string>();

export function getAutoMemoryRoot(projectRoot: string): string {
  const cacheKey = `${getMemoryBaseDir()}\0${projectRoot}`;
  const cached = _autoMemoryRootCache.get(cacheKey);
  if (cached !== undefined) return cached;

---

[Suggestion] QWEN_CODE_MEMORY_BASE_DIR doesn't resolve paths — paths.ts:89

Returns the raw env var string without path.resolve(). Compare with Storage.getRuntimeBaseDir() which resolves paths via resolvePath(). A tilde-prefixed value (~/my-memory) would be used literally.

    return path.resolve(process.env['QWEN_CODE_MEMORY_BASE_DIR']);

---

[Suggestion] Test coverage gaps — store.test.ts

1. No test verifies that QWEN_RUNTIME_DIR env var (highest-priority path inside getRuntimeBaseDir()) drives memory paths correctly through getAutoMemoryRoot.
2. No test checks what happens when runtimeBaseDir changes between two getAutoMemoryRoot calls without clearing the cache — the exact production scenario behind the Critical cache bug above.

— qwen3.7-max via Qwen Code /review

[wenshao]

[Critical] Changing from getGlobalQwenDir() to getRuntimeBaseDir() silently relocates auto-memory from ~/.qwen/projects/... to <runtimeOutputDir>/projects/.... There is no migration logic, no symlink, and no fallback read from the old path. Users who have advanced.runtimeOutputDir set in settings.json will experience unexplained loss of all accumulated auto-memory (user preferences, project knowledge, feedback).

Suggested fix: Add a one-time migration — when the new path doesn't exist but the old getGlobalQwenDir()-based path does, either copy/symlink the old tree or fall back to reading from the old path with a deprecation log.

— qwen3.7-max via Qwen Code /review

[he-yufeng]

Pushed 389a389 for the review feedback.

Changes:

• keyed the auto-memory root cache by the runtime-specific memory base dir plus project root, so daemon sessions with different runtime output dirs no longer reuse each other's managed memory root;
• resolved QWEN_CODE_MEMORY_BASE_DIR before using it, matching the absolute-path behavior expected by the other runtime path settings;
• added regression coverage for QWEN_RUNTIME_DIR priority, runtime-context cache separation without clearing the cache, and relative QWEN_CODE_MEMORY_BASE_DIR resolution.

Validation:

• npm run test --workspace=@qwen-code/qwen-code-core -- src/memory/store.test.ts — 10 passed
• npx eslint packages/core/src/memory/paths.ts packages/core/src/memory/store.test.ts
• npm run typecheck --workspace=@qwen-code/qwen-code-core
• npx prettier --check packages/core/src/memory/paths.ts packages/core/src/memory/store.test.ts
• git diff --check

[wenshao]

No issues found. LGTM! ✅ — qwen3.7-max via Qwen Code /review

[tanzhenxin]

Review

Re-reviewed against the latest commit. The earlier concern — the auto-memory root cache being keyed only by project root, which could serve a stale root once the memory base became runtime-dependent — is resolved: the cache key now includes the runtime base dir (and the local-memory flag), with added test coverage for the multi-runtime case.

Remaining items are low-severity and fine as follow-ups: a release-notes line for users who already set a runtime dir (their existing ~/.qwen memory tree becomes orphaned, not lost), and a docs refresh for the now-relative memory path.

Verdict

APPROVE — correct, runtime-consistent fix for the split-root bug; the one substantive concern from the prior pass is fixed with tests, and only doc/migration polish remains.