fix(core): confirm command substitutions consistently - #4523
Closed
Jerry2003826 wants to merge 1 commit into
Closed
Conversation
Jerry2003826
marked this pull request as ready for review
May 25, 2026 23:50
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4093
Summary
askinstead of hard-denying only when relevant permission rules exist.Contains command_substitutionin shell execution confirmation details and render it in the CLI confirmation prompt.Root Cause
Command substitution handling was split across permission layers. ShellToolInvocation's default permission path treated command substitutions as normal non-read-only commands (
ask), but PermissionManager's shell default fallback returneddenywhen it was invoked for unmatched sub-commands. That made behavior depend on whether existing permission rules were considered relevant.Validation
npm run test --workspace=@qwen-code/qwen-code-core -- src/permissions/permission-manager.test.tsnpm run test --workspace=@qwen-code/qwen-code-core -- src/tools/shell.test.tsnpm run test --workspace=packages/cli -- src/ui/components/messages/ToolConfirmationMessage.test.tsxnpm run lint --workspace=@qwen-code/qwen-code-corenpm run lint --workspace=packages/clinpm run typecheck --workspace=@qwen-code/qwen-code-corenpm run typecheck --workspace=packages/clinpx prettier --check packages/core/src/permissions/permission-manager.ts packages/core/src/tools/shell.ts packages/core/src/tools/tools.ts packages/core/src/confirmation-bus/types.ts packages/core/src/permissions/permission-manager.test.ts packages/core/src/tools/shell.test.ts packages/cli/src/ui/components/messages/ToolConfirmationMessage.tsx packages/cli/src/ui/components/messages/ToolConfirmationMessage.test.tsx