-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(serve): add POST /session/:id/recap #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
doudouOUC
merged 4 commits into
QwenLM:daemon_mode_b_main
from
doudouOUC:feat/daemon-session-recap
May 26, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
01323fd
feat(serve): add POST /session/:id/recap
doudouOUC 058bde7
docs(serve): reconcile recap cancellation docs with actual v1 behavior
doudouOUC 40c23ee
docs(serve): finish recap cancellation reconciliation in acpAgent ext…
doudouOUC 0a19311
docs(serve): finish recap cancellation reconciliation across bridge +…
doudouOUC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The ~30-line
sessionRecapext-method handler has no test coverage.acpAgent.test.tstests other ext-method handlers (rewindSession,renameSession,workspaceMcp, etc.) butsessionRecapis absent. The uncovered paths include:RequestError.invalidParamson missing/invalid sessionId,sessionOrThrowfor unknown sessions,generateSessionRecap(config, signal)return value wrapping, andrecap: nullpass-through.Consider adding a
describeblock mirroring the existingrenameSessiontest pattern to pin the routing, parameter validation, and response shape.— qwen3.7-max via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — agreed, will add. Deferring to a follow-up PR to keep this one focused on chiga0's doc-only gate. The follow-up will add a
describe('SERVE_CONTROL_EXT_METHODS.sessionRecap')block inacpAgent.test.tsmirroring therenameSessionpattern, covering: success path,recap: nullpass-through,RequestError.invalidParamson missing/invalidsessionId,SESSION_ID_RErejection (will also be added — sibling handlers enforce it but recap currently doesn't), andsessionOrThrowon unknown session.