Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 43 additions & 50 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,73 +1,66 @@
<!--
Help reviewers verify this PR quickly.
Maintainers prioritize PRs with a clear reviewer test plan — without it, review may be delayed.

Maintainers prioritize PRs that include clear proof of work.
If a PR does not include enough validation detail to reproduce and verify the change efficiently, review may be delayed.
Don't hard-wrap paragraphs: GitHub renders single newlines as <br>, so wrapped text shows as a narrow column. Write each paragraph or list item as one long line.
-->

## Summary
## What this PR does

- What changed:
- Why it changed:
- Reviewer focus:
<!-- What this PR does. Describe the change in prose, not by file or function names. -->

## Validation
## Why it's needed

<!--
Be concrete. Do not write only "tested locally".
Include the exact commands, prompts, outputs, logs, screenshots, or videos that prove the change was actually run and observed.
<!-- Why it's needed: the motivation, the problem being solved, or the user-facing benefit. -->

## Reviewer Test Plan

For user-visible changes, bug fixes, CLI / TUI behavior changes, or interaction changes, include key screenshots or a short video.
When possible, show before/after behavior.
<!--
How a reviewer can confirm this PR: reproduction steps, expected vs observed behavior, and evidence. CI runs on macOS, Windows, and Linux — Tested on is what you verified locally.

If helpful, use the `e2e-testing` skill to gather stronger end-to-end validation evidence.
User-visible / TUI: Before/After with tmux-real-user-testing skill, screenshots, or a short recording.
Non–user-visible (refactor, types, docs): commands and output below; write N/A under Before/After.
-->

- Commands run:
```bash
# paste commands here
```
- Prompts / inputs used:
- Expected result:
- Observed result:
- Quickest reviewer verification path:
- Evidence (output, logs, screenshots, video, JSON, before/after, etc.):
### How to verify

## Scope / Risk
<!-- How you reproduced it and what a reviewer should confirm — steps if needed, expected vs observed behavior. Focus on outcomes; paste logs or test output when helpful. -->

- Main risk or tradeoff:
- Not covered / not validated:
- Breaking changes / migration notes:
### Evidence (Before & After)

## Testing Matrix
<!-- User-visible / TUI changes: paste before-and-after screenshots, tmux logs, or video side by side. Non-UI changes (docs, refactor, types): N/A -->

<!--
Use:
- ✅ tested
- ⚠️ not tested
- N/A
If anything is ⚠️, explain why briefly below.
-->
### Tested on

| OS | Status |
| :--------: | :----: |
| 🍏 macOS | |
| 🪟 Windows | |
| 🐧 Linux | |

| | 🍏 | 🪟 | 🐧 |
| -------- | --- | --- | --- |
| npm run | ⚠️ | ⚠️ | ⚠️ |
| npx | ⚠️ | ⚠️ | ⚠️ |
| Docker | ⚠️ | ⚠️ | ⚠️ |
| Podman | ⚠️ | N/A | N/A |
| Seatbelt | ⚠️ | N/A | N/A |
<!-- ✅ tested · ⚠️ not tested · N/A -->

Testing matrix notes:
### Environment (optional)

-
<!-- Local runtime: e.g. npm run dev, Docker/Podman sandbox, seatbelt. N/A if only unit tests. -->

## Linked Issues / Bugs
## Risk & Scope

- Main risk or tradeoff:
- Not validated / out of scope:
- Breaking changes / migration notes:

## Linked Issues

<!--
If this PR fully resolves an issue, use one of:
- Closes #<issue_number>
- Fixes #<issue_number>
- Resolves #<issue_number>
Closes #N / Fixes #N / Resolves #N to auto-close.
Otherwise reference without a closing keyword.
-->

<details>
<summary>中文说明</summary>

Otherwise reference related issues without a closing keyword.
<!--
完整翻译上面的英文正文,逐段对应,不要省略或缩写。PR 标题保持英文。
-->

</details>
13 changes: 4 additions & 9 deletions .qwen/commands/qc/create-pr.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,10 @@ Create a well-structured pull request with proper description and title.

3. **Write PR description**

- Use PR Template below
- Summarize changes clearly
- Include context and motivation
- List any breaking changes
- Link related issues if provided, or use "No linked issues"
- Leave the "Screenshots / Video Demo" section empty for the author to fill in
manually
- Add this line at the end of PR body: "🤖 Generated with [Qwen
Code](https://github.com/QwenLM/qwen-code)", with a line separator
- Fill in the PR template below — each section's HTML comment explains what
to write. PR title stays in English.
- Append at the end of the PR body, with a line separator: "🤖 Generated
with [Qwen Code](https://github.com/QwenLM/qwen-code)"

4. **Set up PR**

Expand Down
30 changes: 28 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,24 @@
This file provides guidance to Qwen Code when working with code in this
repository.

## Working Principles

### Simplicity First

**Minimum code that solves the problem. Nothing speculative.**
**(This is the principle we care about most.)**

- No features beyond what was asked.
- No abstractions for single-use code.
- No "flexibility" or "configurability" that wasn't requested.
- No error handling for impossible scenarios.
- If you write 200 lines and it could be 50, rewrite it.

Ask yourself: "Would a senior engineer say this is overcomplicated?" If yes,
simplify.

_Adapted from Andrej Karpathy's [CLAUDE.md](https://github.com/multica-ai/andrej-karpathy-skills/blob/main/CLAUDE.md)._

## Common Commands

### Building
Expand Down Expand Up @@ -101,6 +119,9 @@ npm run preflight # Full check: clean → install → format → lint → build
between packages
- **Tests**: Collocated with source (`file.test.ts` next to `file.ts`),
vitest framework
- **File naming**: `PascalCase.tsx` for React components, `kebab-case.ts` for
new non-component files. Leave existing `camelCase` files alone — renaming breaks `git blame` and imports.
- **Comments**: Default to none. Add only when _why_ is non-obvious; don't delete existing ones as cleanup.
- **Commits**: Conventional Commits (e.g., `feat(cli): Add --json flag`)
- **Node.js**: Development and production both require `>=22` (Ink 7 + React 19.2 requirement)

Expand Down Expand Up @@ -158,8 +179,13 @@ applicable.

- **PR description**: explain the motivation and changes in prose. Avoid
referencing file names or function names.
- **Reviewer Test Plan**: describe behaviors a reviewer should verify and what
to expect, not scripted test commands.
- **Reviewer Test Plan** (template section): describe behaviors a reviewer
should verify and what to expect, not scripted test commands. Use **How to
verify** for reproduction steps; Before/After for TUI evidence when
applicable.
- **Line wrapping**: do not hard-wrap the PR body at a fixed column width.
GitHub renders single newlines as `<br>`, so a wrapped description displays
as a narrow column. Write each paragraph or list item as one long line.

## Project Directories

Expand Down
Loading
Loading