Skip to content

fix(test): raise timeout for Windows installer end-to-end tests #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 2 commits into from
May 20, 2026
Merged

fix(test): raise timeout for Windows installer end-to-end tests #4352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e027d
fix(test): raise timeout for Windows installer end-to-end tests
wenshao May 20, 2026
7a06517
fix(test): raise timeout for Linux/macOS installer end-to-end tests
wenshao May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/tests/install-script.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,10 @@ describe('standalone release packaging', () => {
});
});

describe('Linux/macOS installer end-to-end', () => {
// These end-to-end installs spawn child processes via execFileSync;
// the default 5s vitest timeout is too tight on slow CI runners even
// without Windows' cmd.exe + node.exe startup overhead.
describe('Linux/macOS installer end-to-end', { timeout: 15000 }, () => {

@wenshao wenshao May 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Numeric literals 15000 / 30000 lack separators, but line 379 in this file uses 30_000. Consider 15_000 and 30_000 for intra-file consistency.

Suggested change
describe('Linux/macOS installer end-to-end', { timeout: 15000 }, () => {
describe('Linux/macOS installer end-to-end', { timeout: 15_000 }, () => {

— qwen-latest-series-invite-beta-v34 via Qwen Code /review

itOnUnix(
'installs a local standalone archive with checksum verification',
() => {
Expand Down Expand Up @@ -881,7 +884,9 @@ describe('Linux/macOS installer end-to-end', () => {
});
});

describe('Windows installer end-to-end', () => {
// Windows runners are slower at spawning cmd.exe + node.exe, so the
// default 5s vitest timeout is too tight for these end-to-end installs.
describe('Windows installer end-to-end', { timeout: 30000 }, () => {
itOnWindows(
'installs a local standalone archive with checksum verification',
() => {
Expand Down
Loading