Skip to content

fix(test): count result messages instead of assistant messages in multi-model E2E test #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomelo-nwu merged 1 commit into from
May 20, 2026
Merged

fix(test): count result messages instead of assistant messages in multi-model E2E test #4341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions integration-tests/sdk-typescript/system-control.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ describe('System Control (E2E)', () => {

try {
const systemMessages: Array<{ model?: string }> = [];
let responseCount = 0;
let turnCount = 0;
const resolvers: Array<() => void> = [];
const responsePromises = [
new Promise<void>((resolve) => resolvers.push(resolve)),
Expand All @@ -265,11 +265,11 @@ describe('System Control (E2E)', () => {
}
if (isSDKResultMessage(message)) {
resultWaiter.notifyResult();
}
if (isSDKAssistantMessage(message)) {
if (responseCount < resolvers.length) {
resolvers[responseCount]?.();
responseCount++;
// Resolve on result (one per turn), not assistant message
// (which may fire multiple times per turn: thinking + text)
if (turnCount < resolvers.length) {
resolvers[turnCount]?.();
turnCount++;
}
}
}
Expand Down
Loading