fix(serve): sync E2E baseline with PR20/PR21 capabilities - #4293
Closed
doudouOUC wants to merge 1 commit into
Closed
fix(serve): sync E2E baseline with PR20/PR21 capabilities#4293doudouOUC wants to merge 1 commit into
doudouOUC wants to merge 1 commit into
Conversation
Follow-up to #4284. The Wave 4 merges added `workspace_file_bytes`, `workspace_file_write` (PR 20) and `auth_device_flow` (PR 21) to `SERVE_CAPABILITY_REGISTRY` and the unit-level baseline in `packages/cli/src/serve/server.test.ts`, but the E2E baseline at `integration-tests/cli/qwen-serve-routes.test.ts:190` was not updated, breaking `main` E2E across Linux (sandbox:none / docker) and macOS: expected [ 'health', 'capabilities', …(31) ] to deeply equal […(28)] + "workspace_file_bytes", + "workspace_file_write", + "auth_device_flow", Adds the three tags in registry order so the `caps.features` deep-equal matches the advertised list again. 🤖 Generated with [Qwen Code](https://github.com/QwenLM/qwen-code)
Contributor
📋 Review SummaryThis PR fixes a test baseline mismatch in the E2E capabilities test by adding three missing feature tags ( 🔍 General Feedback
🎯 Specific Feedback🔵 Low
// Issue #4175 PR 20 — bounded raw byte reads
'workspace_file_bytes',
// Issue #4175 PR 20 — hash-aware text mutation
'workspace_file_write',
// Issue #4175 PR 21 — device-flow auth surface
'auth_device_flow',This matches the documentation style already used in ✅ Highlights
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the E2E capabilities baseline in the serve routes integration test to include the three new capability tags (workspace_file_bytes, workspace_file_write, auth_device_flow) that landed in PR 20 / PR 21 but weren't mirrored into the integration mirror, causing the main E2E to fail.
Changes:
- Append the three new tags in registry order to the
caps.featuresdeep-equal baseline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wenshao
reviewed
May 18, 2026
wenshao
left a comment
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI failing: Test (ubuntu-latest, Node 22.x). This PR fixes the exact E2E baseline mismatch that is causing the CI failure — the three added capability tags match SERVE_CAPABILITY_REGISTRY order and correctly omit the conditional require_auth. — qwen-latest-series-invite-beta-v28 via Qwen Code /review
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
Author
|
Superseded by #4282, which merged after this PR was opened and bundled the same three baseline additions ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_file_bytes,workspace_file_write) and PR 21 (auth_device_flow) merges, the E2Ecaps.featuresbaseline atintegration-tests/cli/qwen-serve-routes.test.ts:190lagged behindSERVE_CAPABILITY_REGISTRYand the unit-level list inpackages/cli/src/serve/server.test.ts, breakingmainE2E across Linux (sandbox:none / docker) and macOS.The failing assertion on
main(e.g. run 26040351119):Test plan
npx vitest run packages/cli/src/serve/server.test.ts -t "advertises"— unit-level baseline still passes (registry source-of-truth).main E2E Testsworkflow on this branch to confirmqwen-serve-routes.test.ts > capabilities envelopeis green on Linux sandbox:none / sandbox:docker / macOS.🤖 Generated with Qwen Code