-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(cli): add session path status command #4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
734ee9d
b952ad5
f06c2eb
fe50141
f875a06
ff18330
a472595
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -891,7 +891,7 @@ export async function main() { | |
| settings, | ||
| ); | ||
|
|
||
| const prompt_id = Math.random().toString(16).slice(2); | ||
| const prompt_id = createNonInteractivePromptId(config.getSessionId()); | ||
|
|
||
| if (inputFormat === InputFormat.STREAM_JSON) { | ||
| const trimmedInput = (input ?? '').trim(); | ||
|
|
@@ -948,6 +948,10 @@ export async function main() { | |
| } | ||
| } | ||
|
|
||
| export function createNonInteractivePromptId(sessionId: string): string { | ||
| return `${sessionId}########0`; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] The Consider exporting the constant from core and importing it here: import { MAIN_SESSION_PROMPT_ID_DELIMITER } from '@qwen-code/qwen-code-core';— mimo-v2.5-pro via Qwen Code /review |
||
| } | ||
|
|
||
| function setWindowTitle(title: string, settings: LoadedSettings) { | ||
| if (!settings.merged.ui?.hideWindowTitle) { | ||
| const windowTitle = computeWindowTitle(title); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
createNonInteractivePromptIdis exported but always returns the same deterministic string ({sessionId}########0) for every call within a session. The function name implies uniqueness, and downstream log-analysis tools that group byprompt_idwill merge distinct non-interactive requests into one.Consider either renaming to
createSessionCorrelationIdto set correct expectations, or appending a monotonic counter:— mimo-v2.5-pro via Qwen Code /review