feat(core): add image+video support for Qwen3.6-35B-A3B quant variants - #4106
Conversation
Add modality pattern for qwen3.6-35b model names, enabling image and video input for locally-hosted Qwen3.6-35B-A3B models (e.g. SGLang's default model name: Qwen3.6-35B-A3B-NVFP4). Previously these fell through to the text-only catch-all, blocking all image content. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
| expect(m.audio).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('returns image + video for qwen3.6-35b variants', () => { |
There was a problem hiding this comment.
[Suggestion] Test name says "variants" (plural) but only tests a single variant qwen3.6-35b-a3b-nvfp4. The regex /^qwen3\.6-35b/ is broad (matches all qwen3.6-35b-* models), so testing only one variant leaves a gap where future regex narrowing could silently regress other variants.
Consider either:
- Renaming to
'returns image + video for qwen3.6-35b-a3b-nvfp4'to accurately reflect scope, or - Adding additional test cases for bare
qwen3.6-35band a quant-stripped variant likeqwen3.6-35b-fp16
Nice to have: Add a normalization test with provider prefix (e.g., dashscope/qwen3.6-35b-a3b-nvfp4) in the normalization describe block.
— DeepSeek/deepseek-v4-pro via Qwen Code /review
tanzhenxin
left a comment
There was a problem hiding this comment.
Approved. This is a narrow modality-default update: the qwen3.6-35b rule is ordered before the general qwen fallback, normalization preserves the intended local/quantized model prefix, and the focused modality test passes locally. I also spot-checked the upstream model card and it documents image and video input support.
QwenLM#4106) Add modality pattern for qwen3.6-35b model names, enabling image and video input for locally-hosted Qwen3.6-35B-A3B models (e.g. SGLang's default model name: Qwen3.6-35B-A3B-NVFP4). Previously these fell through to the text-only catch-all, blocking all image content. Co-authored-by: Tyler <tyler@dinsmoor.us> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> (cherry picked from commit 4c18f13)
feat(core): add image+video support for Qwen3.6-35B-A3B quant variants
Note: the following was ai generated, I just had the above mentioned model work through this specific issue when running the same model on my network but wasn't able to have it look at images/video, but the model card on hugginface says it supports it. Probably could expand to whatever other 3.6 models exist but I am just adding support for the one I use.
Summary
/^qwen3\.6-35b/inpackages/core/src/core/modalityDefaults.tswith{ image: true, video: true }, and a corresponding test inmodalityDefaults.test.ts.Qwen3.6-35B-A3B*. Model names matchingqwen3.6-35b*previously fell through to the text-only catch-allqwenpattern, causingcreateMediaContentPart()to silently discard base64-encoded images before they reached the LLM API. The Qwen3.6-35B-A3B model natively supports multimodal input (image + video per HuggingFace).qwen3-coder-(text-only) but before the finalqwencatch-all.Validation
defaultModalities('qwen3.6-35b-a3b-nvfp4')returns{ image: true, video: true }imageandvideomodalities aretrue;pdfandaudioareundefined(not explicitly enabled).defaultModalities('Qwen3.6-35B-A3B-NVFP4')→imageistrue.Scope / Risk
qwenstill absorbs any unrecognized variants. No behavior changes for any existing model line.Testing Matrix
Testing matrix notes: