Repository navigation
fix(core): prevent auto-memory recall from blocking main request #3814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 9 commits into
QwenLM:main
from
B-A-M-N:fix/auto-memory-recall-blocking-main-request
May 5, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
025d6ec
fix(core): prevent auto-memory recall from blocking main request (iss…
B-A-M-N 40ea81a
fix(test): remove stripThoughtsFromHistory from GeminiChat mocks
B-A-M-N 3a0d597
fix(core): address PR #3814 review comments on auto-memory recall dea…
B-A-M-N 8e3a1f3
fix(core): address PR #3814 review findings for auto-memory recall
B-A-M-N 5fb6d0e
fix(core): start auto-memory recall deadline at initiation time
B-A-M-N e36308f
fix(core): address PR #3814 review feedback
B-A-M-N 47b9d02
fix(core): address PR #3814 round 3 review feedback
B-A-M-N 14ae8d6
test(core): assert abort propagation in relevance selector
B-A-M-N c53ca48
fix(lint): remove unused eslint-disable directive in relevanceSelecto…
B-A-M-N File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The slow-recall test verifies that memory content is excluded from the main request (the result), but does not verify that
recallAbortController.abort()was actually called (the mechanism). If theonDeadlinecallback is refactored away, the test still passes while production silently wastes resources.Consider capturing the
AbortSignalpassed tomockMemoryManager.recall, advancing timers past the deadline, and assertingcapturedSignal.aborted === true.— deepseek-v4-pro via Qwen Code /review