-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(vscode-companion): fill slash commands into input on Enter instead of auto-submitting #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yiliang114
merged 5 commits into
main
from
worktree-fix+1990-slash-command-fill-on-enter
Apr 30, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5eb5a17
fix(vscode-companion): fill slash commands into input on Enter instea…
yiliang114 ffce3d1
merge: resolve conflicts with main in Session ACP module
yiliang114 f92fd6a
fix(acp): derive input field from argumentHint and subCommands, not j…
yiliang114 407708b
fix(vscode-companion): strip U+200B from completion insertion path
yiliang114 75e4e87
fix(vscode-companion): add stripZeroWidthSpaces to @qwen-code/webui m…
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Critical] Falling through here uses the generic insertion path, which reads
inputElement.textContentdirectly. If the empty editor contains theU+200Bheight placeholder, filling a slash command can preserve that hidden character and produce text like\u200B/commit.shouldSendMessagestrips the placeholder only for the emptiness check, but the actualsendMessagepayload still uses the raw text, so downstream slash-command handling may not recognize the command.Please normalize the text used for completion insertion, for example by stripping
U+200Bbefore computingtextBeforeCursor/newText, and ensure the value passed tosetInputTextis placeholder-free. Be careful to adjust cursor offsets after normalization.— gpt-5.5 via Qwen Code /review