Skip to content

feat(cli): add Traditional Chinese (zh-TW) as a UI language option #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 17 commits into from
Apr 24, 2026
Merged

feat(cli): add Traditional Chinese (zh-TW) as a UI language option #3569

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
28e1600
feat(cli): add Traditional Chinese (zh-TW) as a UI language option
MikeWang0316tw Apr 24, 2026
d849354
fix: use upstream unused-keys-only-in-locales.json to resolve conflict
MikeWang0316tw Apr 24, 2026
3d542a0
revert: remove check-i18n.ts changes to avoid pre-existing zh.js issues
MikeWang0316tw Apr 24, 2026
bcc92ea
feat(cli): add Traditional Chinese (zh-TW) as a UI language option
MikeWang0316tw Apr 24, 2026
cb51281
fix(cli): add WITTY_LOADING_PHRASES to zh-TW locale
MikeWang0316tw Apr 24, 2026
89c4955
fix(cli): sync zh-TW.js with en.js keys, fix double-escape, fix check…
MikeWang0316tw Apr 24, 2026
ccbde3d
fix: resolve conflict in unused-keys-only-in-locales.json
MikeWang0316tw Apr 24, 2026
e3db54c
fix(cli): add missing Performance translation to zh-TW
MikeWang0316tw Apr 24, 2026
3374d47
fix(cli): add quotes to Performance key in zh-TW
MikeWang0316tw Apr 24, 2026
3555bd5
fix(cli): regenerate zh-TW.js with correct multi-line value parsing
MikeWang0316tw Apr 24, 2026
1382c3a
fix: resolve conflict in unused-keys-only-in-locales.json
MikeWang0316tw Apr 24, 2026
0bd40bc
fix(cli): regenerate zh-TW.js with correct multi-line value parsing
MikeWang0316tw Apr 24, 2026
fc23c1e
fix(cli): standardize zh-TW.js key quoting and sync zh.js keys
MikeWang0316tw Apr 24, 2026
7eedd5f
chore: merge origin/main and resolve zh.js conflicts
MikeWang0316tw Apr 24, 2026
522aad4
fix(cli): update loading phrases when UI language changes
MikeWang0316tw Apr 24, 2026
c8d4fae
fix(i18n): normalize locale separators and fix case-insensitive langu…
MikeWang0316tw Apr 24, 2026
a5c3ed9
fix(test): update getLanguageNameFromLocale mock to include zh-TW
MikeWang0316tw Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/cli/src/i18n/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
export type SupportedLanguage =
| 'en'
| 'zh'
| 'zh-TW'
| 'ru'
| 'de'
| 'ja'
Expand Down Expand Up @@ -38,6 +39,12 @@ export const SUPPORTED_LANGUAGES: readonly LanguageDefinition[] = [
fullName: 'Chinese',
nativeName: '中文',
},
{
code: 'zh-TW',

@wenshao wenshao Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Critical] Adding zh-TW after the generic zh entry breaks the new locale for users who keep general.language on auto. detectSystemLanguage() walks SUPPORTED_LANGUAGES in order and uses startsWith(), so zh-TW/zh-TW.UTF-8 matches zh first and still resolves to Simplified Chinese.

Suggested change
code: 'zh-TW',
{
code: 'zh-TW',
id: 'zh-TW',
fullName: 'Traditional Chinese',
nativeName: '繁體中文',
},
{
code: 'zh',
id: 'zh-CN',
fullName: 'Chinese',
nativeName: '中文',
},

— gpt-5.4 via Qwen Code /review

id: 'zh-TW',
fullName: 'Traditional Chinese',
nativeName: '繁體中文',
},
{
code: 'ru',
id: 'ru-RU',
Expand Down
Loading
Loading