Skip to content

fix(core): treat empty 'pages' parameter as unset in ReadFile #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 1 commit into from
Apr 23, 2026
+9 −1
Merged

fix(core): treat empty 'pages' parameter as unset in ReadFile #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/tools/read-file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,14 @@ describe('ReadFileTool', () => {
expect(() => tool.build(params)).not.toThrow();
});

it('should treat empty pages parameter as unset', () => {
const params: ReadFileToolParams = {
file_path: path.join(tempRootDir, 'test.txt'),
pages: '',
};
expect(() => tool.build(params)).not.toThrow();
});

it('should support offset and limit for text files', async () => {
const filePath = path.join(tempRootDir, 'paginated.txt');
const lines = Array.from({ length: 20 }, (_, i) => `Line ${i + 1}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tools/read-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class ReadFileTool extends BaseDeclarativeTool<
return 'Limit must be a positive number';
}

if (params.pages !== undefined) {
if (params.pages) {
const parsed = parsePDFPageRange(params.pages);
if (!parsed) {
return `Invalid pages parameter: '${params.pages}'. Use formats like '5' or '1-10'.`;
Expand Down
Loading