Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/core/src/core/openaiContentGenerator/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { OpenAIContentGenerator } from './openaiContentGenerator.js';
import {
DashScopeOpenAICompatibleProvider,
DeepSeekOpenAICompatibleProvider,
MiniMaxOpenAICompatibleProvider,
ModelScopeOpenAICompatibleProvider,
OpenRouterOpenAICompatibleProvider,
type OpenAICompatibleProvider,
Expand All @@ -26,6 +27,7 @@ export {
type OpenAICompatibleProvider,
DashScopeOpenAICompatibleProvider,
DeepSeekOpenAICompatibleProvider,
MiniMaxOpenAICompatibleProvider,
OpenRouterOpenAICompatibleProvider,
} from './provider/index.js';

Expand Down Expand Up @@ -87,6 +89,14 @@ export function determineProvider(
);
}

// Check for MiniMax provider
if (MiniMaxOpenAICompatibleProvider.isMiniMaxProvider(config)) {
return new MiniMaxOpenAICompatibleProvider(
contentGeneratorConfig,
cliConfig,
);
}

// Default provider for standard OpenAI-compatible APIs
return new DefaultOpenAICompatibleProvider(contentGeneratorConfig, cliConfig);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export { ModelScopeOpenAICompatibleProvider } from './modelscope.js';
export { DashScopeOpenAICompatibleProvider } from './dashscope.js';
export { DeepSeekOpenAICompatibleProvider } from './deepseek.js';
export { OpenRouterOpenAICompatibleProvider } from './openrouter.js';
export { MiniMaxOpenAICompatibleProvider } from './minimax.js';
export { DefaultOpenAICompatibleProvider } from './default.js';
export type {
OpenAICompatibleProvider,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
/**
* @license
* Copyright 2025 Qwen
* SPDX-License-Identifier: Apache-2.0
*/

import { describe, it, expect, vi, beforeEach } from 'vitest';
import type OpenAI from 'openai';
import { MiniMaxOpenAICompatibleProvider } from './minimax.js';
import type { ContentGeneratorConfig } from '../../contentGenerator.js';
import type { Config } from '../../../config/config.js';

// Mock OpenAI client to avoid real network calls
vi.mock('openai', () => ({
default: vi.fn().mockImplementation((config) => ({
config,
})),
}));

describe('MiniMaxOpenAICompatibleProvider', () => {
let provider: MiniMaxOpenAICompatibleProvider;
let mockContentGeneratorConfig: ContentGeneratorConfig;
let mockCliConfig: Config;

beforeEach(() => {
vi.clearAllMocks();

mockContentGeneratorConfig = {
apiKey: 'test-minimax-api-key',
baseUrl: 'https://api.minimax.io/v1',
model: 'MiniMax-M2.7',
} as ContentGeneratorConfig;

mockCliConfig = {
getCliVersion: vi.fn().mockReturnValue('1.0.0'),
getProxy: vi.fn().mockReturnValue(undefined),
} as unknown as Config;

provider = new MiniMaxOpenAICompatibleProvider(
mockContentGeneratorConfig,
mockCliConfig,
);
});

describe('isMiniMaxProvider', () => {
it('returns true when baseUrl contains api.minimax.io', () => {
const result = MiniMaxOpenAICompatibleProvider.isMiniMaxProvider(
mockContentGeneratorConfig,
);
expect(result).toBe(true);
});

it('returns true when baseUrl contains api.minimaxi.com', () => {
const config = {
...mockContentGeneratorConfig,
baseUrl: 'https://api.minimaxi.com/v1',
} as ContentGeneratorConfig;
expect(MiniMaxOpenAICompatibleProvider.isMiniMaxProvider(config)).toBe(
true,
);
});

it('returns false for non-MiniMax baseUrl', () => {
const config = {
...mockContentGeneratorConfig,
baseUrl: 'https://api.openai.com/v1',
} as ContentGeneratorConfig;
expect(MiniMaxOpenAICompatibleProvider.isMiniMaxProvider(config)).toBe(
false,
);
});

it('returns false when baseUrl is undefined', () => {
const config = {
...mockContentGeneratorConfig,
baseUrl: undefined,
} as ContentGeneratorConfig;
expect(MiniMaxOpenAICompatibleProvider.isMiniMaxProvider(config)).toBe(
false,
);
});
});

describe('getDefaultGenerationConfig', () => {
it('returns temperature 1.0 as default', () => {
expect(provider.getDefaultGenerationConfig()).toEqual({
temperature: 1.0,
});
});
});

describe('buildRequest', () => {
const userPromptId = 'prompt-123';

it('removes response_format from request', () => {
const request = {
model: 'MiniMax-M2.7',
messages: [{ role: 'user' as const, content: 'Hello' }],
response_format: { type: 'json_object' as const },
} as OpenAI.Chat.ChatCompletionCreateParams;

const result = provider.buildRequest(request, userPromptId);
expect(result).not.toHaveProperty('response_format');
});

it('sets temperature to 1.0 when temperature is 0', () => {
const request: OpenAI.Chat.ChatCompletionCreateParams = {
model: 'MiniMax-M2.7',
messages: [{ role: 'user', content: 'Hello' }],
temperature: 0,
};

const result = provider.buildRequest(request, userPromptId);
expect(result.temperature).toBe(1.0);
});

it('sets temperature to 1.0 when temperature is undefined', () => {
const request: OpenAI.Chat.ChatCompletionCreateParams = {
model: 'MiniMax-M2.7',
messages: [{ role: 'user', content: 'Hello' }],
};

const result = provider.buildRequest(request, userPromptId);
expect(result.temperature).toBe(1.0);
});

it('preserves valid temperature values', () => {
const request: OpenAI.Chat.ChatCompletionCreateParams = {
model: 'MiniMax-M2.7',
messages: [{ role: 'user', content: 'Hello' }],
temperature: 0.7,
};

const result = provider.buildRequest(request, userPromptId);
expect(result.temperature).toBe(0.7);
});

it('preserves messages unchanged', () => {
const request: OpenAI.Chat.ChatCompletionCreateParams = {
model: 'MiniMax-M2.7',
messages: [
{ role: 'user', content: 'Hello' },
{ role: 'assistant', content: 'Hi there' },
],
};

const result = provider.buildRequest(request, userPromptId);
expect(result.messages).toHaveLength(2);
expect(result.messages?.[0].content).toBe('Hello');
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/**
* @license
* Copyright 2025 Qwen
* SPDX-License-Identifier: Apache-2.0
*/

import type OpenAI from 'openai';
import type { GenerateContentConfig } from '@google/genai';
import type { Config } from '../../../config/config.js';
import type { ContentGeneratorConfig } from '../../contentGenerator.js';
import { DefaultOpenAICompatibleProvider } from './default.js';

const MINIMAX_DEFAULT_BASE_URL = 'https://api.minimax.io/v1';

/**
* Provider for MiniMax API (OpenAI-compatible interface).
*
* MiniMax-specific constraints:
* - temperature must be in the range (0.0, 1.0]; 0 is not allowed, default is 1.0
* - response_format is not supported and must be removed from requests
*/
export class MiniMaxOpenAICompatibleProvider extends DefaultOpenAICompatibleProvider {
constructor(
contentGeneratorConfig: ContentGeneratorConfig,
cliConfig: Config,
) {
super(contentGeneratorConfig, cliConfig);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Constructor mutates this.contentGeneratorConfig after the super() call.

Sibling providers (DashScope, DeepSeek) leave the config unchanged and apply defaults in buildClient() via destructuring fallback. If any code holds a reference to the original config object, it won't see the updated baseUrl.

Consider applying the default URL in buildClient() or via a protected getter, matching sibling patterns.

— qwen3.6-plus via Qwen Code /review

// Use MiniMax default base URL if not explicitly configured
if (!this.contentGeneratorConfig.baseUrl) {
this.contentGeneratorConfig = {
...this.contentGeneratorConfig,
baseUrl: MINIMAX_DEFAULT_BASE_URL,
};
}
}

/**
* Checks if the configuration targets the MiniMax API.
*/
static isMiniMaxProvider(config: ContentGeneratorConfig): boolean {
const baseUrl = config.baseUrl ?? '';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nice to have] isMiniMaxProvider uses bare substring matching (baseUrl.includes(...)).

A URL like https://proxy.example.com?target=api.minimax.io.malicious.com would false-positive. Consider using new URL(baseUrl).hostname with a more precise check. Very low probability in practice, but worth noting for correctness.

— qwen3.6-plus via Qwen Code /review

return (
baseUrl.includes('api.minimax.io') || baseUrl.includes('api.minimaxi.com')
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
);
}

/**
* MiniMax default generation config.
* Temperature defaults to 1.0 because MiniMax does not accept temperature = 0.
*/
override getDefaultGenerationConfig(): GenerateContentConfig {
return {
temperature: 1.0,
};
}

/**
* Build a MiniMax-compatible request by:
* 1. Ensuring temperature is within the allowed range (0.0, 1.0]
* 2. Removing unsupported `response_format` parameter
*/
override buildRequest(
request: OpenAI.Chat.ChatCompletionCreateParams,
userPromptId: string,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] buildRequest uses any type and delete instead of typed destructuring.

The method casts to any and uses delete to remove response_format. This disables type checking and conflicts with the project's strict/noImplicitAny conventions.

Suggested change
userPromptId: string,
const { response_format: _, ...rest } = baseRequest;
const temperature = (rest.temperature === 0 || rest.temperature == null)
? 1.0
: rest.temperature;
return { ...rest, temperature } as OpenAI.Chat.ChatCompletionCreateParams;

— qwen3.6-plus via Qwen Code /review

): OpenAI.Chat.ChatCompletionCreateParams {
const baseRequest = super.buildRequest(request, userPromptId);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const result: any = { ...baseRequest };

// MiniMax does not support temperature = 0; default to 1.0
if (result.temperature === 0 || result.temperature === undefined) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Temperature check doesn't guard against null.

The OpenAI SDK types temperature as number | null | undefined. If null is passed, it bypasses both guards and gets sent to the API.

Suggested change
if (result.temperature === 0 || result.temperature === undefined) {
if (result.temperature == null || result.temperature === 0) {

— qwen3.6-plus via Qwen Code /review

result.temperature = 1.0;
}

// MiniMax does not support response_format
if ('response_format' in result) {
delete result.response_format;
}

return result as OpenAI.Chat.ChatCompletionCreateParams;
}
}
2 changes: 2 additions & 0 deletions packages/core/src/core/tokenLimits.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ const PATTERNS: Array<[RegExp, TokenCount]> = [
// -------------------
// MiniMax
// -------------------
[/^minimax-m2\.7/i, LIMITS['200k']], // MiniMax-M2.7: 200K
[/^minimax-m2\.5/i, LIMITS['192k']], // MiniMax-M2.5: 196,608
[/^minimax-/i, LIMITS['200k']], // MiniMax fallback: 200K

Expand Down Expand Up @@ -185,6 +186,7 @@ const OUTPUT_PATTERNS: Array<[RegExp, TokenCount]> = [
[/^glm-4\.7/, LIMITS['16k']],

// MiniMax
[/^minimax-m2\.7/i, LIMITS['64k']], // MiniMax-M2.7: 64K output
[/^minimax-m2\.5/i, LIMITS['64k']],

// Kimi
Expand Down
Loading