docs: fix Memory Import Processor link in settings.md - #2627
Closed
joeytoday wants to merge 4 commits into
Closed
Conversation
Update the broken link to point to the correct Memory Import Processor documentation path Fixes #2618 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
joeytoday
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
March 24, 2026 05:37
Contributor
📋 Review SummaryThis PR fixes a broken documentation link in 🔍 General Feedback
🎯 Specific FeedbackNo specific issues identified in this review. ✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
joeytoday
force-pushed
the
docs-update-by-joeytoday
branch
2 times, most recently
from
March 24, 2026 09:05
e7e03fc to
7c0cd8a
Compare
Address review feedback on PR #3325: 1. Local Inference is NOT listed as an auth method — moved to a separate 'Local Model Setup' section with clear note that it is manual settings.json configuration, not an auth flow. 2. .qwen workspace note preserved with original meaning (server-side organizational workspace for cost tracking), not changed to local directory description. 3. All links now consistently provide dual-region URLs: Beijing (bailian.console.aliyun.com) and intl (modelstudio.console.alibabacloud.com). 4. 'Device authorization flow failed' kept scoped to legacy OAuth flow with explicit note, not generalized to API key/local inference. Closes #3316
wenshao
requested changes
Apr 19, 2026
| { | ||
| "modelProviders": { | ||
| "openai": [ | ||
| { |
Collaborator
There was a problem hiding this comment.
[Critical] The new local-model setup examples configure modelProviders.openai without any envKey (and without settings.security.auth.apiKey). That conflicts with docs/users/configuration/model-providers.md, which says each entry must include envKey, and with the current OpenAI-compatible auth validation, which rejects missing keys. As written, users who copy this snippet will hit an auth error instead of getting a working Ollama/vLLM setup.
Suggested change
| { | |
| { | |
| "env": { | |
| "OLLAMA_API_KEY": "ollama" | |
| }, | |
| "modelProviders": { | |
| "openai": [ | |
| { | |
| "id": "qwen3:32b", | |
| "name": "Qwen3 32B (Ollama)", | |
| "envKey": "OLLAMA_API_KEY", | |
| "baseUrl": "http://localhost:11434/v1", | |
| "description": "Qwen3 32B running locally via Ollama" | |
| } | |
| ] | |
| }, | |
| "security": { | |
| "auth": { | |
| "selectedType": "openai" | |
| } | |
| }, | |
| "model": { | |
| "name": "qwen3:32b" | |
| } | |
| } |
Please apply the same fix pattern to the vLLM example as well.
— gpt-5.4 via Qwen Code /review
Contributor
|
This pull request has had no activity for 60 days and is being marked as stale. It will be closed in another 30 days if no further activity occurs. To keep it open, push a new commit or leave a comment. Maintainers may apply |
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Automated review pass. No high-confidence blocking issues found.
Documentation-only changes. The broken link fix (../configuration/memory → ../../developers/tools/memory.md), removal of Qwen OAuth references, and new API Key / Ollama / vLLM setup sections all look correct. No code changes introduced.
Generated by Claude Code
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Automated review pass. One high-confidence finding on the link fix.
| - Scope: Provides context relevant to the entire project or a significant portion of it. | ||
| - **Concatenation & UI Indication:** The contents of all found context files are concatenated (with separators indicating their origin and path) and provided as part of the system prompt. The CLI footer displays the count of loaded context files, giving you a quick visual cue about the active instructional context. | ||
| - **Importing Content:** You can modularize your context files by importing other Markdown files using the `@path/to/file.md` syntax. For more details, see the [Memory Import Processor documentation](../configuration/memory). | ||
| - **Importing Content:** You can modularize your context files by importing other Markdown files using the `@path/to/file.md` syntax. For more details, see the [Memory Import Processor documentation](../../developers/tools/memory.md). |
Collaborator
There was a problem hiding this comment.
[High] The new link target ../../developers/tools/memory.md resolves to docs/developers/tools/memory.md, which documents the save_memory tool (saving/recalling facts to ~/.qwen/QWEN.md) — a completely different feature from the "Memory Import Processor" referenced by the link text (the @path/to/file.md import syntax described earlier in this same sentence).
The old link (../configuration/memory) was a 404 on main, so this change is technically an improvement, but the link text still does not match the target content. Users clicking "Memory Import Processor documentation" will land on unrelated save_memory tool docs.
Consider either:
- Removing the link and expanding the
@path/to/file.mdimport syntax documentation inline here, or - Creating a dedicated page for the Memory Import Processor and linking to it, or
- Updating the link text to match what the target page actually covers.
— automated review via Qwen Code
Collaborator
|
@qwen-code /resolve |
Merge origin/main into docs-update-by-joeytoday branch to resolve conflicts. All conflicts resolved by taking origin/main's changes: - README.md: Main branch revamped with cleaner structure (#5257) - settings.md: Fixed memory doc link path (../features/memory.md) - commands.md: Updated /recap section with proper examples - overview.md: Expanded auth section with new 3-option menu - quickstart.md: Updated ModelStudio branding and auth flow - troubleshooting.md: Added --safe-mode FAQ entry The PR's intended fix (memory link) was already correctly addressed in main.
Collaborator
|
Qwen Code resolved the merge conflicts and pushed the branch update. Merge Conflict Resolution SummaryPR #2627: docs: fix Memory Import Processor link in settings.mdBranch: Conflicts Resolved1. README.md (2 conflicts)
2. docs/users/configuration/settings.md (1 conflict)
3. docs/users/features/commands.md (1 conflict)
4. docs/users/overview.md (1 conflict)
5. docs/users/quickstart.md (2 conflicts)
6. docs/users/support/troubleshooting.md (1 conflict)
|
qwen-code-ci-bot
approved these changes
Jul 5, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No changes to review — the latest merge commit (4bde090) resolved all conflicts by taking origin/main's changes, making this branch identical to main. The originally intended fix (memory doc link) was already addressed in main.
— qwen3.7-max via Qwen Code /review
Collaborator
|
The changes this PR intended to make have already been addressed in
After merging latest Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken documentation link in settings.md that was pointing to an incorrect path.
Changes
../configuration/memoryRelated Issue
Fixes #2618
Changelog
Updated CHANGELOG.md for v0.0.15 release.