Fix: Installation script permission check for arch os and add sudo check - #1877
Merged
Conversation
DennisYu07
requested review from
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
February 19, 2026 09:20
Contributor
📋 Review SummaryThis PR enhances the installation script with improved permission checks for Arch Linux and adds sudo availability checks. The changes significantly improve the script's robustness by adding support for multiple package managers, glibc version checking, and automatic PATH configuration. Overall, these changes make the installation process more reliable across different systems. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
Author
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…rmission Fix: Installation script permission check for arch os and add sudo check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


TLDR
This PR enhances the installation script (install-qwen-with-source.sh) with robust cross-platform support, adds safety checks to prevent system directory corruption, and introduces glibc version validation.
Dive Deeper
Installation Script Improvements:
Reviewer Test Plan
Run
./scripts/installation/install-qwen-with-source.shand restart the terminal to check whether Nodejs and Qwen installed successfullyRun
curl -fsSL https://qwen-code-assets.oss-cn-hangzhou.aliyuncs.com/installation/install-qwen.sh | bashand restart the terminal to check whether Nodejs and Qwen installed successfullyTesting Matrix
Linked issues / bugs
Fix: #1869