Skip to content

fix(cli): route sandbox diagnostic messages to stderr #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanzhenxin merged 1 commit into from
Feb 6, 2026
Merged

fix(cli): route sandbox diagnostic messages to stderr #1735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/cli/src/utils/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { promisify } from 'node:util';
import type { Config, SandboxConfig } from '@qwen-code/qwen-code-core';
import { FatalSandboxError } from '@qwen-code/qwen-code-core';
import { randomBytes } from 'node:crypto';
import { writeStdoutLine, writeStderrLine } from './stdioHelpers.js';
import { writeStderrLine } from './stdioHelpers.js';

const execAsync = promisify(exec);

Expand Down Expand Up @@ -292,7 +292,7 @@ export async function start_sandbox(
});
// install handlers to stop proxy on exit/signal
const stopProxy = () => {
writeStdoutLine('stopping proxy ...');
writeStderrLine('stopping proxy ...');
if (proxyProcess?.pid) {
process.kill(-proxyProcess.pid, 'SIGTERM');
}
Expand All @@ -316,7 +316,7 @@ export async function start_sandbox(
`Proxy command '${proxyCommand}' exited with code ${code}, signal ${signal}`,
);
});
writeStdoutLine('waiting for proxy to start ...');
writeStderrLine('waiting for proxy to start ...');
await execAsync(
`until timeout 0.25 curl -s http://localhost:8877; do sleep 0.25; done`,
);
Expand Down Expand Up @@ -547,7 +547,7 @@ export async function start_sandbox(
containerName = `gemini-cli-integration-test-${randomBytes(4).toString(
'hex',
)}`;
writeStdoutLine(`ContainerName: ${containerName}`);
writeStderrLine(`ContainerName: ${containerName}`);
} else {
let index = 0;
const containerNameCheck = execSync(
Expand All @@ -559,7 +559,7 @@ export async function start_sandbox(
index++;
}
containerName = `${imageName}-${index}`;
writeStdoutLine(`ContainerName (regular): ${containerName}`);
writeStderrLine(`ContainerName (regular): ${containerName}`);
}
args.push('--name', containerName, '--hostname', containerName);

Expand Down Expand Up @@ -783,7 +783,7 @@ export async function start_sandbox(
});
// install handlers to stop proxy on exit/signal
const stopProxy = () => {
writeStdoutLine('stopping proxy container ...');
writeStderrLine('stopping proxy container ...');
execSync(`${config.command} rm -f ${SANDBOX_PROXY_NAME}`);
};
process.on('exit', stopProxy);
Expand All @@ -805,7 +805,7 @@ export async function start_sandbox(
`Proxy container command '${proxyContainerCommand}' exited with code ${code}, signal ${signal}`,
);
});
writeStdoutLine('waiting for proxy to start ...');
writeStderrLine('waiting for proxy to start ...');
await execAsync(
`until timeout 0.25 curl -s http://localhost:8877; do sleep 0.25; done`,
);
Expand Down Expand Up @@ -872,15 +872,15 @@ async function imageExists(sandbox: string, image: string): Promise<boolean> {
}

async function pullImage(sandbox: string, image: string): Promise<boolean> {
writeStdoutLine(`Attempting to pull image ${image} using ${sandbox}...`);
writeStderrLine(`Attempting to pull image ${image} using ${sandbox}...`);
return new Promise((resolve) => {
const args = ['pull', image];
const pullProcess = spawn(sandbox, args, { stdio: 'pipe' });

let stderrData = '';

const onStdoutData = (data: Buffer) => {
writeStdoutLine(data.toString().trim()); // Show pull progress
writeStderrLine(data.toString().trim()); // Show pull progress
};

const onStderrData = (data: Buffer) => {
Expand All @@ -898,7 +898,7 @@ async function pullImage(sandbox: string, image: string): Promise<boolean> {

const onClose = (code: number | null) => {
if (code === 0) {
writeStdoutLine(`Successfully pulled image ${image}.`);
writeStderrLine(`Successfully pulled image ${image}.`);
cleanup();
resolve(true);
} else {
Expand Down Expand Up @@ -942,13 +942,13 @@ async function ensureSandboxImageIsPresent(
sandbox: string,
image: string,
): Promise<boolean> {
writeStdoutLine(`Checking for sandbox image: ${image}`);
writeStderrLine(`Checking for sandbox image: ${image}`);
if (await imageExists(sandbox, image)) {
writeStdoutLine(`Sandbox image ${image} found locally.`);
writeStderrLine(`Sandbox image ${image} found locally.`);
return true;
}

writeStdoutLine(`Sandbox image ${image} not found locally.`);
writeStderrLine(`Sandbox image ${image} not found locally.`);
if (image === LOCAL_DEV_SANDBOX_IMAGE_NAME) {
// user needs to build the image themselves
return false;
Expand All @@ -957,7 +957,7 @@ async function ensureSandboxImageIsPresent(
if (await pullImage(sandbox, image)) {
// After attempting to pull, check again to be certain
if (await imageExists(sandbox, image)) {
writeStdoutLine(`Sandbox image ${image} is now available after pulling.`);
writeStderrLine(`Sandbox image ${image} is now available after pulling.`);
return true;
} else {
writeStderrLine(
Expand Down