fix: use openai model instead of index=0 in acp integration test - #1733
Merged
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Mingholy
requested review from
DennisYu07,
LaZzyMan,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
February 5, 2026 13:33
Contributor
📋 Review SummaryThis PR fixes an integration test that was using index=0 to select a model, which could be a qwen-oauth model requiring login. It also adds functionality to properly handle authentication methods in ACP integration and runtime model snapshots. The changes improve the reliability of the integration tests by ensuring they use models that don't require authentication. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
fix: use openai model instead of index=0 in acp integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes integration test that was using index=0 to select a model, which could be a qwen-oauth model requiring login. Also adds functionality to properly handle authentication methods in ACP integration and runtime model snapshots.
Dive Deeper
This PR addresses two main areas:
Integration test fix: Modified the "returns modes on initialize and allows setting mode and model" test to use an OpenAI model instead of the first available model (index=0), which could be a qwen-oauth model requiring authentication. Additionally, updated the "includes authMethods in error data when auth is required" test to intentionally trigger auth errors by attempting to set the first model without authentication.
ACP Authentication Improvements: Added functionality to include authMethods in error responses when authentication is required. This includes:
The changes ensure that when authentication is required, the ACP client receives information about available authentication methods, improving the user experience when dealing with authentication flows.
Reviewer Test Plan
Run the integration tests to verify the fixes work:
Verify that the ACP integration properly handles authentication errors by checking that authMethods are included in error responses.
Test model switching functionality to ensure runtime model snapshots are properly handled.
Confirm that the ModelDialog component correctly displays and handles both registry and runtime models.
Testing Matrix
Linked issues / bugs
None