Add CLI source selection for SDK releases and fix subagent output handler - #1732
Merged
Conversation
- Replace cli_ref input with cli_source choice (build_from_source or npm_latest) - Add support for bundling latest stable CLI from npm - Add bundle-cli-from-npm.js script for npm-based CLI bundling - Fix property naming in nonInteractiveCli.ts (outputUpdateHandler) - Improve integration tests for subagents - Skip creating issue on failure during dry-run mode Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Mingholy
requested review from
DennisYu07,
LaZzyMan,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
February 5, 2026 13:00
Contributor
📋 Review SummaryThis PR enhances the SDK release workflow by introducing configurable CLI source options (build from source vs. npm latest) and fixes a critical bug in subagent tool call output handling. The changes improve release flexibility and fix integration test failures related to subagent execution. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
- Fix SC2086: double quote variables to prevent globbing and word splitting - Fix yamllint quoted-strings: wrap if conditions with double quotes Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Mingholy
had a problem deploying
to
production-release
February 5, 2026 13:51 — with
GitHub Actions
Failure
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
- Remove dist/ directory requirement from workflow (CLI files are in package root) - Update bundle-cli-from-npm.js to use package root directly instead of package/dist Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Mingholy
had a problem deploying
to
production-release
February 5, 2026 14:06 — with
GitHub Actions
Failure
Mingholy
had a problem deploying
to
production-release
February 5, 2026 14:11 — with
GitHub Actions
Error
Mingholy
had a problem deploying
to
production-release
February 5, 2026 14:12 — with
GitHub Actions
Failure
Fix the build order in build_sandbox.js to match build.js. Previously used 'npm run build --workspaces' which doesn't respect dependency order, causing vscode-ide-companion to fail when looking for @qwen-code/webui types that weren't built yet. Now builds packages in correct order: 1. test-utils 2. core 3. cli 4. webui (dependency for vscode-ide-companion) 5. sdk-typescript 6. vscode-ide-companion Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…eleases Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Mingholy
temporarily deployed
to
production-release
February 6, 2026 03:45 — with
GitHub Actions
Inactive
Mingholy
temporarily deployed
to
production-release
February 6, 2026 03:51 — with
GitHub Actions
Inactive
… npm latest+1 patch - Add getNextPatchVersion() to calculate next patch version from npm latest - Fix getNightlyVersion() to use npm latest + 1 patch instead of package.json - Fix getPreviewVersion() to use npm latest + 1 patch instead of nightly version - Add version info logging in workflow for dry-run verification Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…orkflow Add CLI source selection for SDK releases and fix subagent output handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR improves the SDK release workflow by adding a configurable CLI source option, allowing release managers to bundle CLI either from npm (latest stable) or build from source. It also fixes a bug where subagent tool call outputs were not being captured due to incorrect property naming (
outputUpdateHandler).Dive Deeper
SDK Release Workflow Improvements
The
.github/workflows/release-sdk.ymlhas been refactored to support two CLI source modes:build_from_source(default): Builds the CLI from the current branch/ref. This is recommended when releasing the CLI and SDK together to ensure version consistency.npm_latest: Downloads and bundles the latest stable CLI from npm. This is recommended for standalone SDK releases when the CLI hasn't changed.Key changes:
cli_refinput with a structuredcli_sourcechoice inputcli_version_npmstep to fetch the latest stable CLI version from npmcli_downloadstep to download and extract the CLI package from npmcli_buildstep to build CLI from source when neededbundle-cli-from-npm.jsfor npm sources, and the existingbundle-cli.jsfor source buildsNew Script:
bundle-cli-from-npm.jsA new script that copies the CLI from a downloaded npm package into the SDK dist directory. This script:
CLI_PACKAGE_PATHenvironment variablecli.js,vendor/, andlocales/directoriesBug Fix: Subagent Tool Call Output
Fixed a property naming bug in
nonInteractiveCli.ts:taskToolProgressHandlertooutputUpdateHandlerto match the expected interfaceIntegration Test Improvements
Updated
subagents.test.ts:parent_tool_use_idin subagent messagesReviewer Test Plan
Review the workflow changes:
.github/workflows/release-sdk.ymlfor logic correctnessTest the new bundle script (local testing):
Run the integration tests:
Verify the workflow dispatch UI:
cli_sourceinput should present a dropdown with two options:build_from_sourceandnpm_latestTesting Matrix
Notes:
bundle-cli-from-npm.jswas tested locally on macOSyamllintandactwhere possibleLinked issues / bugs