refactor: remove read_many_files tool, add readManyFiles utility for user @-commands - #1673
Merged
Conversation
…user @-commands Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
tanzhenxin
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis and
pomelo-nwu
as code owners
January 31, 2026 04:18
Contributor
📋 Review SummaryThis PR removes the 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Resolved conflicts by: - index.ts: Adopted main's organized structure, added readManyFiles.js export - atCommandProcessor.ts: Kept refactored readManyFiles utility approach - atCommandProcessor.test.ts: Kept tests for refactored approach
pomelo-nwu
approved these changes
Feb 5, 2026
pomelo-nwu
left a comment
Collaborator
There was a problem hiding this comment.
The rubber stamp is ready!
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
refactor: remove read_many_files tool, add readManyFiles utility for user @-commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Removes the
read_many_filestool from the LLM's available tools while retainingread_filefor single-file reads. Introduces a dedicatedreadManyFilesutility for user-triggered bulk file reads via@pathcommands in both interactive CLI and ACP (editor plugin) modes.Key changes:
read_file@file1 @dir @file2in chat or ACP-powered editorsread_many_filestool and unusedgetFullContext()startup feature@ multiple files

@ folder

@ external file in JetBrains IDE

Dive Deeper
Why Remove
read_many_files?The
read_many_filestool allowed LLM to bulk-read files with glob patterns. This was powerful but:read_filehandles single-file reads; users can guide multi-file via conversationread_fileis easier to auditCLI User Experience
@src/utilsand get a clean folder structure view instead of an errorACP Mode (Editor Plugins)
Simplified from ~120 lines of complex tool registry and glob fallback logic to direct path extraction and
readManyFilescall.Breaking Changes
read_many_filestool removed - LLM can no longer bulk-read files via glob patternsgetFullContext()removed from config - unused startup feature for loading entire codebaseReviewer Test Plan
Test @-commands in CLI:
qwen-code # @README.md @src/utils explain theseTest ACP mode (if using editor plugin):
fileDatapartsVerify tool displays:
Test session resume:
Run tests:
Testing Matrix
Tested on macOS - all tests pass.
Linked issues / bugs
🤖 Generated with Qwen Code