fix(ui): resolve auth not updating in top-right corner - #1670
Merged
Conversation
DennisYu07
requested review from
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 30, 2026 07:26
Contributor
📋 Review SummaryThis PR addresses an issue where the authentication indicator in the top-right corner of the UI wasn't updating when users switched authentication methods via 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
✅ Highlights
|
Collaborator
Author
2026-01-29.23.33.35.mov |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…ating fix(ui): resolve auth not updating in top-right corner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
#1648 When switching authentication methods, the auth indicator in the top-right corner failed to update, causing the UI to show an outdated auth status. This PR ensures the indicator correctly reflects the active authentication by syncing UI state with the current auth selection.
Dive Deeper
The issue was that when users switched authentication methods via
/authslash commands, the information bar in the upper right corner did not update to reflect the change. The root cause is the Config object reference remains constant throughout the application lifecycle. When config.refreshAuth() is called, only the internal state of the Config object changes, but the object reference itself stays the same.Changes:
Reviewer Test Plan
/authcommand to switch modelsTesting Matrix
Linked issues / bugs
Fix #1648 issue 2