fix(ci): honor manual preview version input - #1665
Merged
Merged
Conversation
When create_preview_release is enabled, allow the workflow_dispatch version input to control the preview version (and avoid appending a timestamp if a preview id is already provided) to match user intent.
tanzhenxin
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis and
pomelo-nwu
as code owners
January 30, 2026 03:06
Contributor
📋 Review SummaryThis PR fixes the VSCode IDE Companion preview release workflow to properly honor manual version inputs. When creating preview releases, if a version already includes 🔍 General Feedback
🎯 Specific Feedback
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
tanzhenxin
had a problem deploying
to
production-release
February 3, 2026 07:01 — with
GitHub Actions
Failure
tanzhenxin
had a problem deploying
to
production-release
February 3, 2026 07:06 — with
GitHub Actions
Failure
Prevents workflow failure when some platform VSIXes are already published (e.g., darwin-arm64, darwin-x64) during retry runs. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…ew-version-input fix(ci): honor manual preview version input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
versioninput.versionalready includes-preview.<id>(e.g.v0.9.0-preview.0), it is used as-is (no timestamp appended).Dive Deeper
The workflow previously ignored
inputs.versionwhenevercreate_preview_release=true, always deriving preview versions frompackages/vscode-ide-companion/package.jsonplus a timestamp.This change makes the preview flow align with operator intent:
create_preview_release=true+version=v0.9.0-preview.0->release_version=0.9.0-preview.0create_preview_release=true+version=v0.9.0->release_version=0.9.0-preview.<timestamp>create_preview_release=true+ noversion->release_version=<package.json>-preview.<timestamp>Also updates the input description to match behavior and makes
release_tagmatch the computed preview version.Reviewer Test Plan
Release VSCode IDE Companionviaworkflow_dispatchwithdry_run=true.create_preview_release=trueand try:version=v0.9.0-preview.0(expect exact version)version=v0.9.0(expect timestamp appended)version(expect package.json base + timestamp)npm run release:versionargument match the expectedrelease_version.Linked issues / bugs