fix: enable Shift+Tab shortcut in Windows PowerShell - #1607
Merged
Conversation
- Parse CSI sequences regardless of Kitty protocol status - Fix approval mode cycle shortcut not working on Windows - Add test for non-Kitty protocol mode - Update debug log messages for clarity
Contributor
📋 Review SummaryThis PR fixes the Shift+Tab keyboard shortcut not working in Windows PowerShell by enabling CSI sequence parsing regardless of Kitty protocol support status. The changes ensure that special keys like Shift+Tab work correctly across all terminals, not just those with Kitty protocol support. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
LaZzyMan
marked this pull request as ready for review
January 28, 2026 02:14
LaZzyMan
requested review from
DennisYu07,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 28, 2026 02:14
tanzhenxin
reviewed
Jan 29, 2026
tanzhenxin
left a comment
Collaborator
There was a problem hiding this comment.
It does not seem like working in Windows.
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…rshell fix: enable Shift+Tab shortcut in Windows PowerShell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes Shift+Tab keyboard shortcut not working in Windows PowerShell by use tab shortcut on windows instead of shift+Tab.
Dive Deeper
The Problem
The
Shift+Tabshortcut for cycling through approval modes was not working on Windows PowerShell. Because in Windows systems, pressing Shift+Tab in the command line passes the same parameters to Node.js stdin as pressing Tab directly (Shift presses are not captured), using the Shift+Tab shortcut on Windows is highly unstable.The Solution
Reviewer Test Plan
Manual Testing on Windows
Automated Testing
All tests should pass.
Testing Matrix
Linked issues / bugs
Fixes #1600