fix: skip non-existent file imports instead of warning (ENOENT) - #1563
Merged
Conversation
Contributor
📋 Review SummaryThis PR addresses issue #1549 by improving the memory import processor to silently skip non-existent files (ENOENT errors) instead of logging warnings. This prevents false error messages when markdown content contains text patterns like 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
LaZzyMan
marked this pull request as ready for review
January 21, 2026 06:15
LaZzyMan
requested review from
DennisYu07,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 21, 2026 06:15
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…-import fix: skip non-existent file imports instead of warning (ENOENT)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
When processing markdown files with
@pathimports, the memory import processor now silently skips non-existent files (ENOENT errors) instead of logging warnings. This prevents false error messages when markdown content contains text like@Slf4jthat gets incorrectly interpreted as file imports.Dive Deeper
The root cause: markdown files may contain text patterns like
@Slf4j注解or@LogRecordthat look like import directives but are actually just documentation text. When these "paths" don't exist as files, the processor was logging warnings, which confused users.The fix:
isFileNotFoundError()helper to detect ENOENT errors@pathtext in outputReviewer Test Plan
使用@LogRecord注解,使用SLF4J @Slf4j注解Testing Matrix
Linked issues / bugs
Fixes #1549