Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/.size-baseline
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
9256 build-and-publish-image.yml
49610 cd-cua-driver.yml
2076 cd-mobile-mcp.yml
134426 ci.yml
137297 ci.yml
1482 codeql.yml
9389 comment-attachment-guard.yml
1634 desktop-packaging-check.yml
Expand All @@ -40,11 +40,11 @@
5942 qwen-autofix-fork-signal.yml
469165 qwen-autofix.yml
7061 qwen-ci-flaky-rerun.yml
265415 qwen-code-pr-review.yml
265436 qwen-code-pr-review.yml
79041 qwen-fleet-shepherd.yml
22680 qwen-issue-followup-bot.yml
5760 qwen-pr-safety-precheck.yml
1958 qwen-review-runner-schedule.yml
2518 qwen-review-runner-schedule.yml
27648 qwen-triage-finalize.yml
350381 qwen-triage.yml
9657 release-sdk-java.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qwen-code-pr-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3298,7 +3298,7 @@ jobs:
# `[workflow logs](RUN_URL)` markdown link the cross-job dedup
# anchors on, and the retry instruction the timeout flavor needs.
if [ "$never_started" = "true" ]; then
body="**Qwen Code review never started.** No runner picked up the review job before GitHub ended it at the 24-hour queue limit, so no review ran for this head and nothing picks it up on its own. This step cannot see WHY no runner was available: \`ecs-review\` is switched by \`qwen-review-runner-schedule.yml\`, so check its latest run — a pool that is closed by schedule, empty, or all-offline expires the next request the same way. Re-request with \`@qwen-code /review\` once that run shows the pool open. See [workflow logs](${RUN_URL})."
body="**Qwen Code review never started.** No runner picked up the review job before GitHub ended it, so no review ran for this head and nothing picks it up on its own. This step cannot see why: the \`ecs-review\` pool may be closed by schedule, empty or all-offline — \`qwen-review-runner-schedule.yml\` switches it, and its latest run tells those apart — or the run was cancelled while the job was still waiting. Re-request with \`@qwen-code /review\`; if it ends the same way, read that schedule run before requesting again. See [workflow logs](${RUN_URL})."
elif [ "$REVIEW_PR_RESULT" = "cancelled" ]; then
body="**Qwen Code review was cancelled before a review could be posted.** Nothing failed and nothing is retried automatically: the run was cancelled — by an operator, an upstream event, or the job exceeding its execution time limit. If you still want a review of this PR, request one with \`@qwen-code /review\`. See [workflow logs](${RUN_URL})."
else
Expand Down
11 changes: 11 additions & 0 deletions scripts/tests/qwen-pr-review-workflow.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4190,6 +4190,17 @@ describe('fallback comment resilience (PR #8894 incident class)', () => {
expect(r.posted).toContain('@qwen-code /review');
expect(r.posted).not.toContain('did not complete successfully');
expect(r.posted).not.toContain('retried automatically');
// Which CAUSE the body claims is a separate axis from whether the
// branch fires, and it is the one the predicate cannot observe: real
// cancelled runs reach this shape in 10-40 minutes rather than at the
// 24-hour queue cap (an operator cancelling a review still queued, or
// a command-triggered run cancelled while it waited — both on an OPEN
// PR, so the pr_state gate does not filter them). Naming a duration
// would be false by a factor of 40-150x and would send the reader to
// the schedule workflow for something the schedule did not do.
expect(r.posted).not.toContain('24-hour');
expect(r.posted).not.toContain('queue limit');
expect(r.posted).toContain('cancelled while the job was still waiting');
expect(r.summary).toContain('never started by a runner');
}
},
Expand Down
Loading