Repository navigation
feat: add hybrid code mode #11854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add hybrid code mode #11854
Changes from 3 commits
6ab42db
fda09c0
9a0cd57
30b2a6c
6c919b7
02afce8
2ecf53e
4a38632
3239c68
f35beb1
28df8ee
a7315eb
3c69762
34711cf
ce7e57d
fa457bd
ae35809
4c53574
22a9a40
779d689
b1561b7
e6fbdcd
6edd151
f746b88
ed2e58c
4a72ef8
cad9407
1df2386
71ab2c9
68ceea7
f669bd7
f183ce0
71b8502
4a122a6
e81694c
5afe0ce
e1d295c
3dd719a
10d221a
9b41dc0
7faeea6
f6ea27d
ecbb1ae
b98c160
9c5bf63
1658fc8
fb4f947
266a8d6
4307ddc
6a3ae09
dd262a9
6a3902b
eb000e2
a5d9ac1
ddd38e3
f7bab3d
48bed39
cd0dc35
255e9a0
b05ac71
cc7f4c6
209c593
5438ffd
3763118
a3dee29
8ec0228
fb0e8e9
52a5114
b5aa642
44e02c2
8f25c68
4128ff6
494d4a3
b4b5e47
02182f7
1547568
4f6181d
1ff2c86
e49421a
382c141
ceeec7d
c5393c8
887c031
a92e069
d6527ff
a6eabc7
70c78a2
002d5fe
d47bbf9
aec647b
b3154cf
e4b1813
d3b517d
d304548
88aa3d3
78f08c1
3bb29e2
6dbcff3
26385d2
d896aa2
9731e5b
b03e659
aea47f0
9db2e51
44302a0
3bd332b
c229a21
7a7b405
2ff3a71
e9da544
0a054d8
14bc01c
16da3cf
d3eed9c
89bc755
024cab5
a111c36
8a5cb1a
c97fb18
d4f5a76
f42a1c5
119999a
2aa7947
dd46d00
56123df
b918a9a
6c143aa
4f4e85b
47ca708
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,28 @@ | ||
| # CodeModeOnly MVP | ||
|
|
||
| [English](code-mode-only.md) | [简体中文](code-mode-only.zh-CN.md) | ||
|
|
||
| ## Status | ||
|
|
||
| Implemented for [#10377](https://github.com/QwenLM/qwen-code/issues/10377). | ||
| The feature is opt-in and defaults off. | ||
|
|
||
| ## Goal | ||
|
|
||
| Add a `tools.codeModeOnly` setting that replaces the ordinary model-facing | ||
| tool surface with one `exec` JavaScript tool plus the small set of tools that | ||
| must remain direct control-plane calls. `exec` code can call ordinary tools | ||
| Add a `tools.mode: "code_mode_only"` setting that replaces the ordinary | ||
| model-facing tool surface with one `exec` JavaScript tool plus the small set of | ||
| tools that must remain direct control-plane calls. `exec` code can call ordinary tools | ||
| through `tools.<name>(args)` without bypassing Qwen Code's validation, | ||
| permissions, approvals, hooks, telemetry, cancellation, concurrency, or output | ||
| budgets. | ||
|
|
||
| Direct mode is a compatibility boundary: when the setting is false, tool | ||
| Direct mode is a compatibility boundary: when `tools.mode` is `direct`, tool | ||
| registration, deferred-tool behavior, provider requests, and execution remain | ||
| unchanged. | ||
|
|
||
| ## Non-goals | ||
|
|
||
| - Hybrid direct/code exposure. | ||
| - Defining hybrid direct/code exposure; see [Code Mode](code-mode.md). | ||
| - Persistent cells, globals, or values between `exec` calls. | ||
| - Background jobs, `wait`, `yield`, `store`, or `load`. | ||
| - Raw/freeform provider calls. | ||
|
|
@@ -32,27 +34,27 @@ unchanged. | |
| ```json | ||
| { | ||
| "tools": { | ||
| "codeModeOnly": true | ||
| "mode": "code_mode_only" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| The setting resolves once to the effective `ToolMode` value `direct` or | ||
| `code_mode_only`. `ToolRegistry` and the execution surfaces consume that mode. | ||
| `exec` is only registered when the setting is enabled, so disabling the setting | ||
| also removes it from diagnostics and registry listings. | ||
| The setting resolves once to the effective `ToolMode` value. `ToolRegistry` | ||
| and the execution surfaces consume that mode. `exec` is only registered when a | ||
| code mode is enabled, so selecting `direct` also removes it from diagnostics | ||
|
DragonnZhang marked this conversation as resolved.
Resolved
|
||
| and registry listings. | ||
|
|
||
| ## Exposure policy | ||
|
|
||
| The registry remains the source of truth. Exposure is a view over registered | ||
| tools, never a second registry. | ||
|
|
||
| | Category | Model top level | `tools.*` inside `exec` | | ||
| | ------------------------------------------ | ----------------- | ----------------------- | | ||
| | `exec` | CodeModeOnly only | No | | ||
| | Direct control | Yes | No | | ||
| | Ordinary registered tool | No | Yes | | ||
| | Hidden bridge (`tool_search`, `tool_call`) | No | No | | ||
| | Category | Model top level | `tools.*` inside `exec` | | ||
| | ------------------------------------------ | ------------------------------------- | ----------------------- | | ||
| | `exec` | CodeMode and CodeModeOnly | No | | ||
| | Direct control | Yes | No | | ||
| | Ordinary registered tool | CodeMode only | Yes | | ||
| | Hidden bridge (`tool_search`, `tool_call`) | Existing behavior outside strict mode | No | | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-2: N06: The rewritten exposure row conditions the table's only statement about bridge exposure on "strict mode" — a term that exists nowhere in the mode vocabulary, the code, or any other English document — and it groups two tools the code exposes differently.
Witness: Suggested fix: Replace the cell with mode names and split the pair, e.g. two rows — The fix must not violate this existing fact: Acceptance criterion: N/A (documentation prose; no guard, branch or behaviour to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明改写后的 exposure 表格行把该表唯一一句关于 bridge 暴露的说明限定在 "strict mode" 下——而这个词在模式词表、代码和其余文档中都不存在(真实枚举是 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-2: The new Chinese translation states the opposite of the English original (docs/design/code-mode-only.md:144-148) on Code Mode shell concurrency: EN says "Code Mode Bash calls bypass the read-only command classifier, with the model responsible for keeping dependent calls sequential. Other tools retain their existing concurrency classification"; ZH says the batch is "由现有的只读并发分类器处理" and drops the Bash carve-out entirely. A reader working from the ZH design concludes that shell calls submitted together inside one Witness: Suggested fix: Translate the two missing EN sentences into the ZH paragraph, e.g. replace "… The fix must not violate this existing fact: Acceptance criterion: N/A (documentation text; no guard, branch, or behavior to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明新增中文翻译在 Code Mode shell 并发这一点上与英文原文相反:英文说 "Code Mode Bash calls bypass the read-only command classifier",中文写成"由现有的只读并发分类器处理",恰好把豁免说成了适用。同仓库的 code-mode-concurrency.zh-CN.md:21 与英文一致,可证这是翻译错误。实测 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the exposure row's 'strict mode' terminology (docs/design/code-mode-only.md:64). The finding still stands at the current head ( 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:暴露表中自创的“strict mode”术语(docs/design/code-mode-only.md:64)。该发现在当前 head(
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the ZH concurrency translation contradicting the EN original (code-mode-only.zh-CN.md:124) (same finding as the round-1 thread). The finding still stands at the current head ( 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:中文并发翻译与英文原文相反(code-mode-only.zh-CN.md:124)(与第 1 轮讨论串为同一发现)。该发现在当前 head(
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-2: N06: The rewritten exposure row conditions the table's only statement about bridge exposure on "strict mode" — a term that exists nowhere in the mode vocabulary, the code, or any other English document — and it groups two tools the code exposes differently.
Witness: Suggested fix: Replace the cell with mode names and split the pair, e.g. two rows — The fix must not violate this existing fact: Acceptance criterion: N/A (documentation prose; no guard, branch or behaviour to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明改写后的 exposure 表格行把该表唯一一句关于 bridge 暴露的说明限定在 "strict mode" 下——而这个词在模式词表、代码和其余文档中都不存在(真实枚举是 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the exposure row's 'strict mode' terminology (docs/design/code-mode-only.md:64) (same finding as the round-1 thread). The finding still stands at the current head ( 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:暴露表中自创的“strict mode”术语(docs/design/code-mode-only.md:64)(与第 1 轮讨论串为同一发现)。该发现在当前 head( |
||
|
|
||
| The direct-control allowlist is centralized and deliberately small. It covers | ||
| user interaction (`ask_user_question`), delegation (`agent`), terminal output | ||
|
|
@@ -155,14 +157,13 @@ OpenAI-compatible, and Anthropic adapters all receive the structured `exec` | |
| declaration without provider-specific prompting. | ||
|
|
||
| Filtered subagent declarations apply the same policy. For a read-only teammate | ||
| or a fork with an execution allowlist, `exec` is the audited gateway while the | ||
| exact allowed nested names are carried in its invocation context. The same set | ||
| generates the description and is checked again before Core dispatch, so an | ||
| explicit allowlist can narrow code-mode-callable nested tools without becoming | ||
| prompt-only policy, exposing a hidden bridge, or making `exec` recursive. | ||
| For cache-compatible forks, an inherited `exec` declaration represents its | ||
| ordinary bindings: an omitted `fork_tools` inherits them, while an explicit | ||
| list replaces them with the requested subset. | ||
| or a fork with an execution allowlist, `exec` is the audited gateway and the | ||
| nested names carried in its invocation context are checked again before Core | ||
| dispatch. Explicit ordinary-tool entries narrow that nested set. An inherited | ||
| or explicitly allowed `exec` instead represents all surviving ordinary | ||
| code-mode-callable bindings, while the agent's own `tools` list still narrows | ||
| its direct surface. Hidden bridges remain unavailable and `exec` cannot call | ||
| itself. | ||
|
|
||
| ## Failure and rollback | ||
|
|
||
|
|
@@ -171,9 +172,9 @@ closed before scheduling. Invalid arguments continue to fail in the normal | |
| execution chain. A sandbox startup, protocol, timeout, memory, or teardown | ||
| failure becomes an `exec` tool error. | ||
|
|
||
| Rollback is setting `tools.codeModeOnly` to false. No session migration or | ||
| registry cleanup is required because code mode has no persistent state and the | ||
| ordinary registry was never replaced. | ||
| Rollback is setting `tools.mode` to `direct`. No session migration or registry | ||
| cleanup is required because code mode has no persistent state and the ordinary | ||
| registry was never replaced. | ||
|
|
||
| ## Verification | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| # CodeModeOnly MVP | ||
|
|
||
| [English](code-mode-only.md) | [简体中文](code-mode-only.zh-CN.md) | ||
|
|
||
| ## 状态 | ||
|
|
||
| 已为 [#10377](https://github.com/QwenLM/qwen-code/issues/10377) 实现。 | ||
| 该功能为可选功能,默认关闭。 | ||
|
qwen-code-review-bot marked this conversation as resolved.
Resolved
|
||
|
|
||
| ## 目标 | ||
|
|
||
| 新增 `tools.mode: "code_mode_only"` 设置,用一个 `exec` JavaScript 工具和少量 | ||
| 必须保留为直接调用的控制面工具,取代面向模型的普通工具面。`exec` 中的代码可通过 | ||
| `tools.<name>(args)` 调用普通工具,同时不会绕过 Qwen Code 的校验、权限、审批、 | ||
| hook、遥测、取消、并发或输出预算。 | ||
|
|
||
| 直接模式是兼容性边界:当 `tools.mode` 为 `direct` 时,工具注册、延迟工具行为、 | ||
| provider 请求和执行均保持不变。 | ||
|
|
||
| ## 非目标 | ||
|
|
||
| - 定义混合的直接调用和代码调用;详见 [Code Mode](code-mode.zh-CN.md)。 | ||
| - 在多次 `exec` 调用间持久化 cell、全局变量或值。 | ||
| - 后台任务、`wait`、`yield`、`store` 或 `load`。 | ||
| - 原始/freeform provider 调用。 | ||
| - 在 code mode 中提供 `tool_search` 或 `tool_call` bridge。 | ||
| - 提供兼容 Node.js 的 sandbox。 | ||
|
|
||
| ## 配置 | ||
|
|
||
| ```json | ||
| { | ||
| "tools": { | ||
| "mode": "code_mode_only" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| 该设置会解析一次,得到有效的 `ToolMode` 值;`ToolRegistry` 和各执行面使用这一 | ||
| 模式。只有启用某个 code mode 时才注册 `exec`,因此选择 `direct` 也会将它从 | ||
| 诊断信息和 registry 列表中移除。 | ||
|
|
||
| ## 暴露策略 | ||
|
|
||
| registry 仍是事实来源。暴露只是注册工具之上的视图,而不是第二套 registry。 | ||
|
|
||
| | 类别 | 模型顶层调用 | `exec` 内的 `tools.*` | | ||
| | ----------------------------------------- | ------------------------ | --------------------- | | ||
| | `exec` | CodeMode 和 CodeModeOnly | 否 | | ||
| | 直接控制工具 | 是 | 否 | | ||
| | 已注册的普通工具 | 仅 CodeMode | 是 | | ||
| | 隐藏 bridge(`tool_search`、`tool_call`) | 严格模式之外沿用既有行为 | 否 | | ||
|
|
||
| 直接控制 allowlist 集中维护且刻意保持精简。它覆盖用户交互 | ||
| (`ask_user_question`)、委派(`agent`)、终止输出约定、 | ||
| plan/goal/task/team/worktree/session 控制,以及生命周期无法安全隐藏在解释执行程序 | ||
| 后的 ACP host 控制。新工具默认可在 code mode 中调用;增加仅直接调用或隐藏工具时, | ||
| 必须显式修改策略。 | ||
|
|
||
| 延迟工具保持注册状态和延迟 registry 状态,并可从 `exec` 调用。生成的 `exec` | ||
| 描述仍会携带这些工具的完整 schema,以及它们在 `ALL_TOOLS` 中的名称和描述: | ||
| CodeModeOnly 会隐藏 `tool_search`,嵌套调用也不会以 `functionCall` 出现在历史记录 | ||
| 中,因此后续 reveal 无法补充描述里遗漏的 schema。CodeModeOnly 会跳过延迟预加载 | ||
| 和 ToolSearch 提醒,因为二者都不属于它面向模型的协议。 | ||
|
|
||
| ## 确定性的 JavaScript 接口 | ||
|
|
||
| 每次向 provider 同步工具前,都会从当前 registry 生成 `exec` 描述。工具按规范 | ||
| 名称排序。名称会通过替换无效标识符字符来规范化为 JavaScript 属性;如果名称以 | ||
| 数字开头,还会添加前缀。如果两个规范名称映射到同一个属性,则字典序靠前的名称 | ||
| 胜出,并用一条 warning 指出被省略的冲突项。 | ||
|
|
||
| 描述会定义: | ||
|
|
||
| - 全新的异步 JavaScript 执行环境; | ||
| - 用于嵌套调用的 `tools.<normalizedName>(args)`; | ||
| - 包含规范名称和 JavaScript 名称的 `ALL_TOOLS`; | ||
| - `text(value)`、`image(value)`、`audio(value)` 和 `exit()`; | ||
| - 从 JSON Schema 确定性生成的类 TypeScript 签名; | ||
| - 不提供 Node.js、import、网络 API、timer 和持久状态。 | ||
|
DragonnZhang marked this conversation as resolved.
Resolved
|
||
|
|
||
| 嵌套调用返回一个 JSON-safe 对象,其中包含真实 call id、工具名、状态、输出和 | ||
| structured content。调用失败或取消时,guest promise 会使用 scheduler/ACP 错误 | ||
| reject。 | ||
|
|
||
| ## Sandbox 与传输 | ||
|
|
||
| `exec` 在独立子进程中运行编译为 WebAssembly 的 QuickJS。每次调用都会创建全新 | ||
| 的 QuickJS runtime 和 context。子进程通过 stdio 接收精简的 framed JSON 协议; | ||
| 其中不包含工具实现或 Qwen 配置。父进程把 JavaScript 名称映射回规范 registry | ||
| 名称,并分派每次调用。 | ||
|
|
||
| guest 不提供 Node 全局变量、`require`、`process`、文件系统、socket、模块加载器、 | ||
| `console`、timer、`Atomics`、`SharedArrayBuffer` 或 `WebAssembly`。由于没有安装 | ||
| 模块加载器,动态和静态 import 都会失败。runtime 的内存和 stack 限制固定。 | ||
| QuickJS 的 interrupt hook 会限制 guest CPU 预算。当 guest 挂起等待已注册的 host | ||
| 工具时,该预算和父进程的兜底 watchdog 会暂停;在 guest job 再次运行前恢复。 | ||
| 因此,长时间 build 可以继续使用工具声明的 timeout,同时 guest CPU 死循环无法 | ||
| 逃逸固定预算。源码、协议 frame、helper 输出和最终结果都有上限。 | ||
|
|
||
| 取消操作会中止所有嵌套调用并终止子进程。顶层 promise settled 后,也会在 teardown | ||
| 前取消未 await 的嵌套调用。子进程、timer、promise handle 或 guest 全局变量都不 | ||
| 会在调用结束后存活。 | ||
|
|
||
| 子进程只接收最小化且经过清理的环境,guest 无法检查该环境。独立进程为解释器故障 | ||
| 提供纵深防御;QuickJS/WASM 是 guest 的 capability 边界。 | ||
|
|
||
| ## 重入式分派 | ||
|
|
||
| `CoreToolScheduler.schedule()` 无法递归调用:子调用会排在仍在运行的父调用之后, | ||
| 从而形成死锁。因此,scheduler 会在 invocation 边界绑定 async-local | ||
| `ToolCallRuntime` context,`exec` 只与该 context 通信。 | ||
|
|
||
| scheduler runtime 会将同一 event-loop turn 中收到的嵌套调用合并为一批,并通过 | ||
| 使用相同 `Config` 和 observer 配置的 sibling scheduler 执行。这样无需直接调用 | ||
| `tool.execute()`,仍能沿用现有的构建/校验、权限、确认、hook、执行、截断、遥测和 | ||
| 并发链路。guest 的连续 await 会生成连续 batch;`Promise.all` 调用会进入同一个 | ||
| batch,由现有的只读并发分类器处理。嵌套 request id 包含父 id,并携带 | ||
|
Comment on lines
+123
to
+124
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-2: The new Chinese translation states the opposite of the English original (docs/design/code-mode-only.md:144-148) on Code Mode shell concurrency: EN says "Code Mode Bash calls bypass the read-only command classifier, with the model responsible for keeping dependent calls sequential. Other tools retain their existing concurrency classification"; ZH says the batch is "由现有的只读并发分类器处理" and drops the Bash carve-out entirely. A reader working from the ZH design concludes that shell calls submitted together inside one Witness: Suggested fix: Translate the two missing EN sentences into the ZH paragraph, e.g. replace "… The fix must not violate this existing fact: Acceptance criterion: N/A (documentation text; no guard, branch, or behavior to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明新增中文翻译在 Code Mode shell 并发这一点上与英文原文相反:英文说 "Code Mode Bash calls bypass the read-only command classifier",中文写成"由现有的只读并发分类器处理",恰好把豁免说成了适用。同仓库的 code-mode-concurrency.zh-CN.md:21 与英文一致,可证这是翻译错误。实测 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the ZH concurrency translation contradicting the EN original (code-mode-only.zh-CN.md:124). The finding still stands at the current head ( 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:中文并发翻译与英文原文相反(code-mode-only.zh-CN.md:124)。该发现在当前 head( |
||
| `source: code_mode` 和 `parentCallId`。 | ||
|
|
||
| 嵌套 scheduler 更新会合并到所属 scheduler 的可见调用中,嵌套 id 的确认响应也会 | ||
| 委派给它。外层模型仍只接收完整的 `exec` 响应。 | ||
|
|
||
| ACP 沿用其独立审计过的执行链。它的 invocation 边界会绑定相同的 runtime 接口, | ||
| 嵌套分派通过 `Session.runTool` 重入。因此,ACP 顶层和嵌套调用使用相同的 ACP 权限、 | ||
| 审批、hook、遥测、持久化和取消机制,而不是借用 CLI scheduler 状态或直接执行工具。 | ||
| ACP 会串行执行普通嵌套调用,与现有直接工具顺序一致;Core scheduler 则保留现有的 | ||
| 安全只读并行 batch。 | ||
|
|
||
| ## Provider 行为 | ||
|
|
||
| 所有 provider 继续使用 `ToolRegistry` 提供的 `FunctionDeclaration[]`。在 Direct | ||
| 模式下,该数组与现有视图逐字节一致。在 CodeModeOnly 中,它是暴露策略生成的视图, | ||
| 因此 Gemini/Qwen、OpenAI-compatible 和 Anthropic adapter 都会收到结构化的 | ||
| `exec` declaration,不需要 provider 专用 prompt。 | ||
|
|
||
| 经过过滤的子智能体 declaration 使用相同策略。对于只读 teammate 或带执行 | ||
| allowlist 的 fork,`exec` 是经过审计的 gateway,其 invocation context 中携带的嵌套 | ||
| 名称会在 Core 分派前再次校验。显式列出的普通工具会收窄该嵌套集合;继承或显式允许 | ||
| 的 `exec` 则代表所有仍可用的普通 code-mode-callable binding,而智能体自身的 | ||
| `tools` 列表仍会收窄直接调用面。隐藏 bridge 始终不可用,`exec` 也不能调用自身。 | ||
|
|
||
| ## 失败与回滚 | ||
|
|
||
| 未知、冲突、隐藏、仅直接调用和递归请求的工具都会在调度前 fail closed。无效参数 | ||
| 继续在正常执行链中失败。sandbox 启动、协议、timeout、内存或 teardown 失败会转为 | ||
| `exec` 工具错误。 | ||
|
|
||
| 回滚方式是将 `tools.mode` 设为 `direct`。无需迁移 session 或清理 registry, | ||
| 因为 code mode 没有持久状态,且普通 registry 从未被替换。 | ||
|
|
||
| ## 验证 | ||
|
|
||
| 单元和集成测试必须覆盖: | ||
|
|
||
| - Direct 和 CodeModeOnly 暴露、延迟保留、冲突处理、确定性描述和显式子智能体过滤。 | ||
| - 有效/无效 JavaScript、异步顺序、`Promise.all`、helper 输出、throw error、CPU | ||
| 死循环、内存限制、import、不可用全局变量、隔离、输出限制、取消、未 await 工作和 | ||
| 递归调用。 | ||
| - 嵌套权限、确认、Pre/Post hook、失败、输出预算、真实名称遥测/UI 更新、MCP 工具 | ||
| 和 scheduler 死锁回归。 | ||
| - Gemini/Qwen、OpenAI-compatible、Anthropic、headless、interactive、subagent | ||
| 和 ACP 调用面。 | ||
|
|
||
| 只有通过相关 package 测试、build、typecheck、E2E probe 和两轮干净的完整 diff | ||
| 自审,才算实现完成。 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| # Code Mode | ||
|
|
||
| [English](code-mode.md) | [简体中文](code-mode.zh-CN.md) | ||
|
|
||
| ## Status | ||
|
|
||
| Implemented. The feature is experimental and opt-in. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-6: The new hybrid design doc claims full implementation but records nowhere that the Issue #10377 defines hybrid as Witness: Suggested fix: Add a Non-goals (or Scope) section to The fix must not violate this existing fact: AGENTS.md, General workflow §1: "Provide both an English Acceptance criterion: N/A (docs-only; no guard, branch or behaviour to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明新增的 hybrid 设计文档声称"Implemented",却没有任何地方记录所关联 issue 中 hybrid 模式的 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R1-6: The new hybrid design doc claims full implementation but records nowhere that the Issue #10377 defines hybrid as Witness: Suggested fix: Add a Non-goals (or Scope) section to The fix must not violate this existing fact: AGENTS.md, General workflow §1: "Provide both an English Acceptance criterion: N/A (docs-only; no guard, branch or behaviour to pin). Please prove it by removing the fix and confirming that test goes red. 中文说明新增的 hybrid 设计文档声称"Implemented",却没有任何地方记录所关联 issue 中 hybrid 模式的 — qwen3.8-max via Qwen Code /review (v0.25.0)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the next round, not dropped: Critical-only mode is active on this PR and the previous round exhausted its time budget, so this round landed only the blocking agent-core fixes. This documentation correction stays open and is queued for the next round. 中文说明本轮延后处理(并非忽略):本 PR 已处于仅处理 Critical 的模式(takeover 窗口从第 5 轮起算),且上一轮已耗尽时间预算,因此本轮只落地了阻断性的 agent-core 修复(R3-1:nested-only 白名单撤销 hybrid 直接声明;以及 exec 通道的列表/闸门分歧修复)。该建议保持开放,已排入下一轮队列。具体技术细节见上方英文正文。
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the unimplemented 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:未记录
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferred to the follow-up queue — recorded, not implemented in this PR: the unimplemented 中文说明已推迟到后续跟进队列——已记录,不在本 PR 中实现:未记录 |
||
|
|
||
| ## Problem | ||
|
|
||
| Qwen Code currently supports direct tool calls and `CodeModeOnly`. The latter | ||
| replaces ordinary top-level tools with `exec`, which is useful for orchestration | ||
| but prevents a model from choosing direct calls when they are clearer or more | ||
| efficient. Codex models this as three tool modes: direct, hybrid Code Mode, and | ||
| CodeModeOnly. | ||
|
|
||
| ## Goal | ||
|
|
||
| Add a hybrid `CodeMode` option without changing the existing default or | ||
| `CodeModeOnly` behavior. | ||
|
|
||
| ## Configuration | ||
|
|
||
| ```json | ||
| { | ||
| "tools": { | ||
| "mode": "code_mode" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| The effective modes are: | ||
|
|
||
| | `tools.mode` value | Effective mode | | ||
| | ------------------ | ---------------- | | ||
| | omitted / `direct` | `direct` | | ||
| | `code_mode` | `code_mode` | | ||
| | `code_mode_only` | `code_mode_only` | | ||
|
|
||
| This follows Codex's `ToolMode` serialized values. Safe mode and bare mode | ||
| force `direct`. | ||
|
|
||
| ## Exposure policy | ||
|
|
||
| | Surface | `direct` | `code_mode` | `code_mode_only` | | ||
| | -------------------- | ------------------------ | ------------------------------- | ---------------- | | ||
| | Ordinary eager tools | Direct | Direct and nested | Nested only | | ||
| | Deferred tools | `tool_search` | `tool_search` and nested | Nested only | | ||
| | Direct-control tools | Direct | Direct only | Direct only | | ||
| | `exec` | Hidden | Direct | Direct | | ||
| | Hidden bridge tools | Existing direct behavior | Direct where already applicable | Hidden | | ||
|
|
||
| In `code_mode`, ordinary visible tool descriptions gain an `exec` declaration | ||
| for that tool. The `exec` description keeps the complete `ALL_TOOLS` metadata | ||
| but does not duplicate every schema. Deferred tools gain their declaration when | ||
| their normal top-level declaration is revealed. In `code_mode_only`, the | ||
| existing behavior remains: all nested declarations live in the `exec` | ||
| description because no later top-level reveal is possible. | ||
|
|
||
| Filtered subagent declarations preserve the same mode. The agent's `tools` | ||
| list narrows its direct surface. Explicit ordinary-tool execution entries | ||
| narrow the nested set, while an inherited or explicitly allowed `exec` carries | ||
| all surviving code-mode-callable bindings. | ||
|
|
||
| ## Constraints and risks | ||
|
|
||
| - Normal direct declarations must remain byte-for-byte unchanged in `direct`. | ||
| - Nested calls continue through the existing scheduler or ACP execution path; | ||
| the mode must not bypass validation, permissions, hooks, cancellation, or | ||
| telemetry. | ||
| - Duplicating every schema in hybrid mode would increase prompt size, so only | ||
| the per-tool nested declaration is appended there. | ||
|
|
||
| ## Validation | ||
|
|
||
| - Verify mode resolution and safe/bare-mode fallback. | ||
| - Verify direct, hybrid, and CodeModeOnly declaration surfaces. | ||
| - Verify filtered subagent declarations and nested allowlists. | ||
| - Run focused Core and CLI tests, then build and typecheck. | ||
|
|
||
| ## Acceptance criteria | ||
|
|
||
| - `tools.mode: "code_mode"` registers `exec` while retaining ordinary direct | ||
| tools and deferred discovery. | ||
| - Ordinary visible tools advertise their nested JavaScript signature. | ||
| - `tools.mode: "code_mode_only"` selects the stricter behavior. | ||
| - The default, safe-mode, and bare-mode surfaces remain direct-only. | ||
Uh oh!
There was an error while loading. Please reload this page.