Skip to content

fix(core): treat a word-initial # as a comment when splitting shell commands #11821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yiliang114 wants to merge 17 commits into from
Closed

fix(core): treat a word-initial # as a comment when splitting shell commands #11821

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b2b5077
fix(core): treat a word-initial # as a comment when splitting shell c…
yiliang114 Sep 14, 2026
53fd793
fix(core): do not start a comment after an escaped boundary
yiliang114 Sep 14, 2026
9a977d8
fix(core): only treat IFS whitespace as a comment word boundary
yiliang114 Sep 14, 2026
f3cff68
Merge origin/main into fix/issue-11815-shell-comment-splitting
yiliang114 Sep 14, 2026
50459ae
fix(core): keep a # literal where bash does not tokenize a comment
yiliang114 Sep 14, 2026
84bd8ee
fix(core): scope comment detection to substituted bodies (#11821)
yiliang114 Sep 14, 2026
f8f5fef
fix(core): keep an arithmetic `)` out of the substitution depth
yiliang114 Sep 14, 2026
9023b45
Merge branch 'main' into fix/issue-11815-shell-comment-splitting
wenshao Sep 15, 2026
20d53ca
test(core): pin that a process substitution is not a substituted body
yiliang114 Sep 15, 2026
5cdf8ca
fix(core): strip heredoc bodies on Bash-rule paths and drop comment-o…
yiliang114 Sep 15, 2026
5eb2dbe
style(core): satisfy the Prettier gate in permission-manager.test.ts
yiliang114 Sep 16, 2026
93fe54e
fix(core): keep Bash-rule evaluation from failing open on collapsed s…
yiliang114 Sep 16, 2026
4d1eb20
fix(core): keep the comment scan honest about continuations and neste…
yiliang114 Sep 16, 2026
7098e33
fix(core): refuse the heredoc projection when the marker line is cont…
yiliang114 Sep 16, 2026
9895c2a
Merge origin/main into fix/issue-11815-shell-comment-splitting
yiliang114 Sep 16, 2026
6492faf
fix(core): keep a body cd and an odd backslash run from hiding a deny
yiliang114 Sep 16, 2026
93a4101
fix(core): keep the expansions bash runs in an unquoted heredoc body
yiliang114 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading