Skip to content

fix(mesh): keep the existence check when filtering host sessions out of search #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yiliang114 wants to merge 1 commit into from
Closed

fix(mesh): keep the existence check when filtering host sessions out of search #11261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/cli/src/serve/server/session-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,7 +1586,11 @@ export async function searchWorkspaceSessionsForResponse(
for (const hit of hits) {
readOptions.signal?.throwIfAborted();
const item = await sessionService.getSessionListItem(hit.sessionId);
if (item?.sourceType !== MESH_HOST_SESSION_SOURCE_TYPE)
// Both conditions, and in this order. `item?.sourceType !== X` is true
// when the read found nothing, so folding the existence check into the
// optional chain lets a session that vanished between the search hit and
// this read through as an undefined summary.
if (item && item.sourceType !== MESH_HOST_SESSION_SOURCE_TYPE)
bySessionId.set(
hit.sessionId,
applyOrganization(
Expand Down
Loading